Make user name not editable when re-login is required....

Make user name not editable when re-login is required.

BUG=19721
TEST=To test:
(1) Enable sync
(2) Quit chromium
(3) Find Sync Data\BookmarkSyncSettings.sqlite3 in your chromium profile and open it in SQLite Browser.
(4) Edit the record in the 'cookies' table and change the 'service_token' value to 'x'. Save the DB.
(5) Re-launch chromium. You should see a 'Sync Error' notie on the new tab page. Click it and you will see the login window. The username field should contain your login as simply bold text, NOT as an editable input field.

[RandyPosynick, 2009-10-16 17:10:15]

First shot at this.

[tim (not reviewing), 2009-10-29 20:54:55]

http://codereview.chromium.org/283013/diff/1/2
File chrome/browser/sync/resources/gaia_login.html (right):

http://codereview.chromium.org/283013/diff/1/2#newcode63
Line 63: f.Email.style.display = 'none';
when does gaia_setFocus get called? Can this cause a situation where the user
hasn't entered a username ever, does so (say, with a typo), and a password, and
when the page comes back saying "Error signing in", the username is uneditable?

[tim (not reviewing), 2009-11-04 20:55:55]

On 2009/10/29 20:54:55, timsteele wrote:
> http://codereview.chromium.org/283013/diff/1/2
> File chrome/browser/sync/resources/gaia_login.html (right):
> 
> http://codereview.chromium.org/283013/diff/1/2#newcode63
> Line 63: f.Email.style.display = 'none';
> when does gaia_setFocus get called? Can this cause a situation where the user
> hasn't entered a username ever, does so (say, with a typo), and a password,
and
> when the page comes back saying "Error signing in", the username is
uneditable?

Did you have a chance to look into this yet?  I really hate to ask, but I've
been told to finish this issue by Friday for an Mstone4 deadline :(

[ChrisCampbell, 2009-11-05 00:20:53]

Looks like you're right... the proposed patch does assume that the user typed
their email address correctly the first time.

gaia_setFocus() only gets called from showGaiaLogin() a few lines below, but
*that* can get called via JS injection from FlowHandler::ShowGaiaLogin() in
sync_setup_flow.cc.

The error types passed in don't appear to be sufficient to let us distinguish
whether the Email has been successfully authenticated in the past.

A different approach (or more thorough) approach is required.