Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: base/task/cancelable_task_tracker.cc

Issue 2830093003: Replace uses of hash_map in //base (Closed)
Patch Set: WebKit callers Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task/cancelable_task_tracker.cc
diff --git a/base/task/cancelable_task_tracker.cc b/base/task/cancelable_task_tracker.cc
index 0d4e57cfa8b7f68b2e7ccc457850655763b2f0e8..87e34c2dd1038dd94e845fcd9a2e0e2a1174ee1b 100644
--- a/base/task/cancelable_task_tracker.cc
+++ b/base/task/cancelable_task_tracker.cc
@@ -134,7 +134,7 @@ CancelableTaskTracker::TaskId CancelableTaskTracker::NewTrackedTaskId(
void CancelableTaskTracker::TryCancel(TaskId id) {
DCHECK(sequence_checker_.CalledOnValidSequence());
- hash_map<TaskId, CancellationFlag*>::const_iterator it = task_flags_.find(id);
+ const auto it = task_flags_.find(id);
if (it == task_flags_.end()) {
// Two possibilities:
//
@@ -149,13 +149,8 @@ void CancelableTaskTracker::TryCancel(TaskId id) {
void CancelableTaskTracker::TryCancelAll() {
DCHECK(sequence_checker_.CalledOnValidSequence());
-
- for (hash_map<TaskId, CancellationFlag*>::const_iterator it =
- task_flags_.begin();
- it != task_flags_.end();
- ++it) {
- it->second->Set();
- }
+ for (const auto it : task_flags_)
Łukasz Anforowicz 2017/04/24 18:46:10 nit:s/const auto/const auto&/ ?
+ it.second->Set();
}
bool CancelableTaskTracker::HasTrackedTasks() const {
@@ -165,7 +160,6 @@ bool CancelableTaskTracker::HasTrackedTasks() const {
void CancelableTaskTracker::Track(TaskId id, CancellationFlag* flag) {
DCHECK(sequence_checker_.CalledOnValidSequence());
-
bool success = task_flags_.insert(std::make_pair(id, flag)).second;
DCHECK(success);
}

Powered by Google App Engine
This is Rietveld 408576698