Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 2829973002: add customized printing setting for headless (Closed)
Patch Set: adjust command interface and add unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/page_handler.cc
diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc
index def6fe326213508213832bbc40f22c43e8424a6f..6d334431d50f06ea553e7e8b99ff7cbeafac4f5c 100644
--- a/content/browser/devtools/protocol/page_handler.cc
+++ b/content/browser/devtools/protocol/page_handler.cc
@@ -298,7 +298,20 @@ void PageHandler::CaptureScreenshot(
from_surface.fromMaybe(false));
}
-void PageHandler::PrintToPDF(std::unique_ptr<PrintToPDFCallback> callback) {
+void PageHandler::PrintToPDF(Maybe<bool> landscape,
+ Maybe<bool> display_header_footer,
+ Maybe<bool> print_backgrounds,
+ Maybe<double> scale,
+ Maybe<String> unit,
+ Maybe<String> paper_type,
+ Maybe<double> paper_width,
+ Maybe<double> paper_height,
+ Maybe<double> margin_top,
+ Maybe<double> margin_bottom,
+ Maybe<double> margin_left,
+ Maybe<double> margin_right,
+ Maybe<String> page_ranges,
+ std::unique_ptr<PrintToPDFCallback> callback) {
callback->sendFailure(Response::Error("PrintToPDF is not implemented"));
return;
}

Powered by Google App Engine
This is Rietveld 408576698