Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: content/browser/devtools/protocol/page_handler.h

Issue 2829973002: add customized printing setting for headless (Closed)
Patch Set: nit change Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/page_handler.h
diff --git a/content/browser/devtools/protocol/page_handler.h b/content/browser/devtools/protocol/page_handler.h
index faace0adfaf25306aba30490bb643e2128e4f982..62d5ebbf23d258a488ebd7875cb6841a2042a165 100644
--- a/content/browser/devtools/protocol/page_handler.h
+++ b/content/browser/devtools/protocol/page_handler.h
@@ -77,7 +77,19 @@ class PageHandler : public DevToolsDomainHandler,
Maybe<int> quality,
Maybe<bool> from_surface,
std::unique_ptr<CaptureScreenshotCallback> callback) override;
- void PrintToPDF(std::unique_ptr<PrintToPDFCallback> callback) override;
+ void PrintToPDF(Maybe<int> dpi,
Lei Zhang 2017/04/20 08:35:58 Not sure how well a DPI setting will be supported.
jzfeng 2017/04/27 06:56:05 Sadly setting different dpi's yield the same pdf f
Eric Seckler 2017/04/27 08:56:59 Lei: Would there be a way to specify a DPI setting
Lei Zhang 2017/04/27 22:17:46 Since we don't expose such a setting, I'd say it's
Eric Seckler 2017/04/28 08:13:06 Let's go without it for now then. I believe someon
+ Maybe<bool> landscape,
+ Maybe<bool> display_header_footer,
+ Maybe<bool> print_backgrounds,
+ Maybe<double> scale,
+ Maybe<String> paper_type,
+ Maybe<String> margin_type,
+ Maybe<double> margin_top,
+ Maybe<double> margin_bottom,
+ Maybe<double> margin_left,
+ Maybe<double> margin_right,
+ Maybe<String> page_ranges,
+ std::unique_ptr<PrintToPDFCallback> callback) override;
Response StartScreencast(Maybe<std::string> format,
Maybe<int> quality,
Maybe<int> max_width,

Powered by Google App Engine
This is Rietveld 408576698