components/resources/BUILD.gn - Issue 2829973002: add customized printing setting for headless

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/resources/BUILD.gn

Issue 2829973002: add customized printing setting for headless (Closed)

Patch Set: use GetRawDataResource to avoid using locale pak Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/resources/BUILD.gn

diff --git a/components/resources/BUILD.gn b/components/resources/BUILD.gn

index 6ead4c71c74a72606066f48a2d67bf57a01915ea..264f92cd172e6aaec47992d7fddd4e62d13b57da 100644

--- a/components/resources/BUILD.gn

+++ b/components/resources/BUILD.gn

@@ -31,7 +31,10 @@ grit("components_resources") {

"-E",

"about_credits_file=" + rebase_path(about_credits_file_bro, root_build_dir),

]

- defines = [ "enable_print_preview=$enable_print_preview" ]

+ defines = [

+ "enable_print_preview_page=$enable_print_preview",

Eric Seckler 2017/05/02 09:35:27 this probably shouldn't be adding "_page" to the i

jzfeng 2017/05/03 00:45:56 Good catch, I forget to remove this suffix. Done.

+ "enable_basic_printing=$enable_basic_printing",

+ ]

deps = [

":compressed_about_credits",