chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java - Issue 2829943002: Redirecting off-origin navigations in PWAs to CCT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 2829943002: Redirecting off-origin navigations in PWAs to CCT. (Closed)

Patch Set: Merge adds launchMode="singleTop" back (removed by pkotwicz@ last week) to avoid kiling WebApkActivity. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/AndroidManifest.xml ('K') | « chrome/android/java/AndroidManifest.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

index 581a891a225b65126d60d74f92f444ce329271f0..3ac57ed918845a1235f8505f5ef88a358582c6db 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

@@ -14,9 +14,11 @@ import android.view.ContextMenu;

import android.webkit.MimeTypeMap;

import org.chromium.base.CollectionUtil;

+import org.chromium.base.CommandLine;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeFeatureList;

+import org.chromium.chrome.browser.ChromeSwitches;

import org.chromium.chrome.browser.firstrun.FirstRunStatus;

import org.chromium.chrome.browser.preferences.ChromePreferenceManager;

import org.chromium.chrome.browser.preferences.datareduction.DataReductionProxyUma;

@@ -256,7 +258,11 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {

ContextMenu menu, Context context, ContextMenuParams params) {

// Add all items in a group

Set<ContextMenuItem> supportedOptions = new HashSet<>();

- if (FirstRunStatus.getFirstRunFlowComplete()) {

+ // Limit context menu to copying until FRE has been completed,

+ // unless FRE has been explicitly disabled (for full context menu in tests).

+ if (FirstRunStatus.getFirstRunFlowComplete()

+ || CommandLine.getInstance().hasSwitch(

+ ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE)) {

supportedOptions.addAll(BASE_WHITELIST);

if (mMode == FULLSCREEN_TAB_MODE) {

supportedOptions.addAll(FULLSCREEN_TAB_MODE_WHITELIST);