Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java

Issue 2829943002: Redirecting off-origin navigations in PWAs to CCT. (Closed)
Patch Set: Fixes for comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInterceptNavigationDelegate.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.webapps; 5 package org.chromium.chrome.browser.webapps;
6 6
7 import android.content.Intent; 7 import android.content.Intent;
8 import android.text.TextUtils; 8 import android.text.TextUtils;
9 9
10 import org.chromium.base.ContextUtils; 10 import org.chromium.base.ContextUtils;
11 import org.chromium.chrome.browser.ShortcutHelper; 11 import org.chromium.chrome.browser.ShortcutHelper;
12 import org.chromium.chrome.browser.tab.BrowserControlsVisibilityDelegate; 12 import org.chromium.chrome.browser.tab.BrowserControlsVisibilityDelegate;
13 import org.chromium.chrome.browser.tab.InterceptNavigationDelegateImpl;
13 import org.chromium.chrome.browser.tab.Tab; 14 import org.chromium.chrome.browser.tab.Tab;
14 import org.chromium.chrome.browser.tab.TabDelegateFactory; 15 import org.chromium.chrome.browser.tab.TabDelegateFactory;
15 import org.chromium.chrome.browser.tab.TabWebContentsDelegateAndroid; 16 import org.chromium.chrome.browser.tab.TabWebContentsDelegateAndroid;
16 import org.chromium.chrome.browser.util.IntentUtils; 17 import org.chromium.chrome.browser.util.IntentUtils;
17 import org.chromium.webapk.lib.client.WebApkNavigationClient; 18 import org.chromium.webapk.lib.client.WebApkNavigationClient;
18 19
19 /** 20 /**
20 * A {@link TabDelegateFactory} class to be used in all {@link Tab} instances ow ned by a 21 * A {@link TabDelegateFactory} class to be used in all {@link Tab} instances ow ned by a
21 * {@link FullScreenActivity}. 22 * {@link FullScreenActivity}.
22 */ 23 */
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 65
65 @Override 66 @Override
66 public TabWebContentsDelegateAndroid createWebContentsDelegate(Tab tab) { 67 public TabWebContentsDelegateAndroid createWebContentsDelegate(Tab tab) {
67 return new WebappWebContentsDelegateAndroid(mActivity, tab); 68 return new WebappWebContentsDelegateAndroid(mActivity, tab);
68 } 69 }
69 70
70 @Override 71 @Override
71 public BrowserControlsVisibilityDelegate createBrowserControlsVisibilityDele gate(Tab tab) { 72 public BrowserControlsVisibilityDelegate createBrowserControlsVisibilityDele gate(Tab tab) {
72 return new WebappBrowserControlsDelegate(mActivity, tab); 73 return new WebappBrowserControlsDelegate(mActivity, tab);
73 } 74 }
75
76 @Override
77 public InterceptNavigationDelegateImpl createInterceptNavigationDelegate(Tab tab) {
pkotwicz 2017/05/02 21:41:41 Drive by: You'll need to modify WebApkActivity#cre
piotrs 2017/05/03 01:05:42 Thanks! I've missed this. Done. WDYT about adding
78 return new WebappInterceptNavigationDelegate(mActivity, tab);
79 }
74 } 80 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInterceptNavigationDelegate.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698