Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2829933003: WebUI: Swap Uglify with Closure Compiler NodeJS version.

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 7 months ago
Reviewers:
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Swap Uglify with Closure Compiler NodeJS version. This unblocks ES6 usage from WebUI code, since Uglify was throwing errors when encountered various ES6 features. BUG=671426 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Update sha1 #

Patch Set 3 : Rewrite licenses such that they are preserved by JS Compiler." #

Patch Set 4 : Tweak regex, add rewrite_licenses.py to dep list. #

Patch Set 5 : Add test. #

Patch Set 6 : Fix bug that appended to same file instead of replacing. #

Patch Set 7 : Fix ChromeOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -10 lines) Patch
M chrome/browser/resources/PRESUBMIT.py View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
A chrome/browser/resources/rewrite_licenses.py View 1 2 3 4 5 6 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/resources/rewrite_licenses_test.py View 1 2 3 4 5 6 1 chunk +76 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/prefs/prefs.js View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/vulcanize.gni View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/vulcanize_gn.py View 1 2 3 4 5 1 chunk +14 lines, -3 lines 0 comments Download
M third_party/node/node_modules.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/node/node_modules.tar.gz.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/node/package.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (28 generated)
dpapad
Description was changed from ========== WebUI: Swap Uglify with Closure Compiler NodeJS version, WIP. BUG= ...
3 years, 8 months ago (2017-04-20 23:05:57 UTC) #1
dpapad
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-20 23:10:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829933003/20001
3 years, 8 months ago (2017-04-20 23:10:59 UTC) #3
dpapad
Description was changed from ========== WebUI: Swap Uglify with Closure Compiler NodeJS version, WIP. BUG= ...
3 years, 8 months ago (2017-04-20 23:11:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-20 23:12:59 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/394458) win_chromium_x64_rel_ng on ...
3 years, 8 months ago (2017-04-20 23:12:59 UTC) #6
dpapad
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-20 23:17:54 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829933003/40001
3 years, 8 months ago (2017-04-20 23:18:07 UTC) #8
dpapad
Patchset #2 (id:20001) has been deleted
3 years, 8 months ago (2017-04-20 23:18:12 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-21 00:08:40 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-21 00:08:40 UTC) #11
dpapad
Description was changed from ========== WebUI: Swap Uglify with Closure Compiler NodeJS version, WIP. This ...
3 years, 8 months ago (2017-04-21 00:53:12 UTC) #12
dpapad
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 01:10:43 UTC) #13
dpapad
Patchset #5 (id:100001) has been deleted
3 years, 7 months ago (2017-05-03 01:11:02 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829933003/80001
3 years, 7 months ago (2017-05-03 01:11:36 UTC) #15
dpapad
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 01:11:43 UTC) #16
dpapad
Description was changed from ========== WebUI: Swap Uglify with Closure Compiler NodeJS version, WIP. This ...
3 years, 7 months ago (2017-05-03 01:12:14 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829933003/120001
3 years, 7 months ago (2017-05-03 01:12:33 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-03 01:48:18 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/375248) win_chromium_rel_ng on ...
3 years, 7 months ago (2017-05-03 01:48:18 UTC) #20
dpapad
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 02:30:41 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829933003/140001
3 years, 7 months ago (2017-05-03 02:31:08 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-03 03:33:53 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/375318)
3 years, 7 months ago (2017-05-03 03:33:53 UTC) #24
dpapad
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 21:33:07 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829933003/160001
3 years, 7 months ago (2017-05-03 21:34:31 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-03 22:46:43 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 22:46:44 UTC) #28 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698