Fail when uploading blob is non-existant

content/browser/loader/resource_dispatcher_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 
 #include <stddef.h>
 
@@ skipping 1159 matching lines @@
         bool call_interceptor = true;
         if (!interceptor_info.starts_with.empty()) {
           call_interceptor =
               base::StartsWith(it.value(), interceptor_info.starts_with,
                                base::CompareCase::INSENSITIVE_ASCII);
         }
         if (call_interceptor) {
           interceptor_info.interceptor.Run(
               it.name(), it.value(), child_id, resource_context,
               base::Bind(
                   &ResourceDispatcherHostImpl::ContinuePendingBeginRequest,

[michaeln, 2017/05/31 22:41:19]

Looks like ContinuePendingBeginRequest can be deferred till later, do we need to
AttachRequestBodyBlobDataHandles before making this async function call?

[horo, 2017/06/01 02:04:48]

OnHttpHeaderReceived() in chrome_content_browser_client_extensions_part.cc is
the only interceptor.
And it is calling the callback synchronously. 

So even if we call AttachRequestBodyBlobDataHandles() before it, the issue will
not be fixed.

[dmurph, 2017/06/01 18:18:29]

Acknowledged.

[michaeln, 2017/06/01 20:46:59]

Oh well, I was hoping that might be the source of (some of) the missing blobs,
guess not.

Since the interceptor interface provides for an async completion code path, it'd
probably be good to rearrange the order so that a new interceptor, or a change
to the existing interceptor, that does use the async completion doesn't tickle
the latent bug.

[kinuko, 2017/06/02 03:15:40]

Moving AttachRequestBodyBlobDataHandle earlier also makes sense, dmurph: mind
changing the order a bit?  Doing it in a follow-up is also fine.

[dmurph, 2017/06/02 19:38:07]

Done.

                   base::Unretained(this), requester_info, request_id,
                   request_data, sync_result_handler, route_id, headers,
                   base::Passed(std::move(mojo_request)),
                   base::Passed(std::move(url_loader_client))));
           return;
         }
       }
     }
   }
   ContinuePendingBeginRequest(
@@ skipping 113 matching lines @@
         GetBlobStorageContext(requester_info->blob_storage_context());
     // Resolve elements from request_body and prepare upload data.
     if (request_data.request_body.get()) {
       // |blob_context| could be null when the request is from the plugins
       // because ResourceMessageFilters created in PluginProcessHost don't have
       // the blob context.
       if (blob_context) {
         // Attaches the BlobDataHandles to request_body not to free the blobs
         // and any attached shareable files until upload completion. These data
         // will be used in UploadDataStream and ServiceWorkerURLRequestJob.
-        AttachRequestBodyBlobDataHandles(request_data.request_body.get(),
-                                         resource_context);
+        bool blobs_alive = AttachRequestBodyBlobDataHandles(
+            request_data.request_body.get(), resource_context);
+        if (!blobs_alive) {
+          AbortRequestBeforeItStarts(requester_info->filter(),
+                                     sync_result_handler, request_id,
+                                     std::move(url_loader_client));
+          return;
+        }
       }
       new_request->set_upload(UploadDataStreamBuilder::Build(
           request_data.request_body.get(), blob_context,
           requester_info->file_system_context(),
           BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE).get()));
     }
 
     allow_download = request_data.allow_download &&
                      IsResourceTypeFrame(request_data.resource_type);
     do_not_prompt_for_login = request_data.do_not_prompt_for_login;
@@ skipping 741 matching lines @@
   new_request->SetExtraRequestHeaders(headers);
 
   new_request->SetLoadFlags(load_flags);
 
   storage::BlobStorageContext* blob_context = GetBlobStorageContext(
       GetChromeBlobStorageContextForResourceContext(resource_context));
 
   // Resolve elements from request_body and prepare upload data.
   ResourceRequestBodyImpl* body = info.common_params.post_data.get();
   if (body) {
-    AttachRequestBodyBlobDataHandles(body, resource_context);
+    bool blobs_alive = AttachRequestBodyBlobDataHandles(body, resource_context);
+    if (!blobs_alive) {
+      new_request->CancelWithError(net::ERR_INSUFFICIENT_RESOURCES);
+      loader->NotifyRequestFailed(false, net::ERR_ABORTED);
+      return;
+    }
     new_request->set_upload(UploadDataStreamBuilder::Build(
         body, blob_context, upload_file_system_context,
         BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE).get()));
   }
 
   // Make extra info and read footer (contains request ID).
   //
   // TODO(davidben): Associate the request with the FrameTreeNode and/or tab so
   // that IO thread -> UI thread hops will work.
   ResourceRequestInfoImpl* extra_info = new ResourceRequestInfoImpl(
@@ skipping 618 matching lines @@
                                  &throttles);
     if (!throttles.empty()) {
       handler.reset(new ThrottlingResourceHandler(std::move(handler), request,
                                                   std::move(throttles)));
     }
   }
   return handler;
 }
 
 }  // namespace content