third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2829923003: Remove redundant WebLocalFrame* parameter from DidReceiveTitle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2829923003: Remove redundant WebLocalFrame* parameter from DidReceiveTitle (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 98558857e655f2f82a0d53c7ddcec32b2640b6da..7dc906231f16446c4d264ee595964ccc71d348a4 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -8809,13 +8809,11 @@ class SwapMainFrameWhenTitleChangesWebFrameClient

remote_frame_->Close();

}

- void DidReceiveTitle(WebLocalFrame* frame,

- const WebString&,

- WebTextDirection) override {

- if (!frame->Parent()) {

+ void DidReceiveTitle(const WebString&, WebTextDirection) override {

+ if (!Frame()->Parent()) {

remote_frame_ =

WebRemoteFrame::Create(WebTreeScopeType::kDocument, nullptr);

- frame->Swap(remote_frame_);

+ Frame()->Swap(remote_frame_);

}