Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2829923003: Remove redundant WebLocalFrame* parameter from DidReceiveTitle (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/shell/test_runner/web_frame_test_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index f68037c8104cdb78070279905363a1603f1e36ed..005ade583726e7001e4fd9ab0c3fb817992e2ccb 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3870,12 +3870,10 @@ void RenderFrameImpl::RunScriptsAtDocumentElementAvailable(
// Do not use |this| or |frame|! ContentClient might have deleted them by now!
}
-void RenderFrameImpl::DidReceiveTitle(blink::WebLocalFrame* frame,
- const blink::WebString& title,
+void RenderFrameImpl::DidReceiveTitle(const blink::WebString& title,
blink::WebTextDirection direction) {
- DCHECK_EQ(frame_, frame);
// Ignore all but top level navigations.
- if (!frame->Parent()) {
+ if (!frame_->Parent()) {
base::trace_event::TraceLog::GetInstance()->UpdateProcessLabel(
routing_id_, title.Utf8());
@@ -3886,7 +3884,7 @@ void RenderFrameImpl::DidReceiveTitle(blink::WebLocalFrame* frame,
}
// Also check whether we have new encoding name.
- UpdateEncoding(frame, frame->View()->PageEncoding().Utf8());
+ UpdateEncoding(frame_, frame_->View()->PageEncoding().Utf8());
}
void RenderFrameImpl::DidChangeIcon(blink::WebIconURL::Type icon_type) {
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/shell/test_runner/web_frame_test_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698