Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Side by Side Diff: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

Issue 2829923003: Remove redundant WebLocalFrame* parameter from DidReceiveTitle (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 WrappedResourceRequest wrapped_request(request); 371 WrappedResourceRequest wrapped_request(request);
372 web_frame_->Client()->DidStartProvisionalLoad( 372 web_frame_->Client()->DidStartProvisionalLoad(
373 WebDataSourceImpl::FromDocumentLoader(loader), wrapped_request); 373 WebDataSourceImpl::FromDocumentLoader(loader), wrapped_request);
374 } 374 }
375 if (WebDevToolsAgentImpl* dev_tools = DevToolsAgent()) 375 if (WebDevToolsAgentImpl* dev_tools = DevToolsAgent())
376 dev_tools->DidStartProvisionalLoad(web_frame_->GetFrame()); 376 dev_tools->DidStartProvisionalLoad(web_frame_->GetFrame());
377 } 377 }
378 378
379 void LocalFrameClientImpl::DispatchDidReceiveTitle(const String& title) { 379 void LocalFrameClientImpl::DispatchDidReceiveTitle(const String& title) {
380 if (web_frame_->Client()) { 380 if (web_frame_->Client()) {
381 web_frame_->Client()->DidReceiveTitle(web_frame_, title, 381 web_frame_->Client()->DidReceiveTitle(title, kWebTextDirectionLeftToRight);
382 kWebTextDirectionLeftToRight);
383 } 382 }
384 } 383 }
385 384
386 void LocalFrameClientImpl::DispatchDidChangeIcons(IconType type) { 385 void LocalFrameClientImpl::DispatchDidChangeIcons(IconType type) {
387 if (web_frame_->Client()) { 386 if (web_frame_->Client()) {
388 web_frame_->Client()->DidChangeIcon(static_cast<WebIconURL::Type>(type)); 387 web_frame_->Client()->DidChangeIcon(static_cast<WebIconURL::Type>(type));
389 } 388 }
390 } 389 }
391 390
392 void LocalFrameClientImpl::DispatchDidCommitLoad( 391 void LocalFrameClientImpl::DispatchDidCommitLoad(
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
997 void LocalFrameClientImpl::AbortClientNavigation() { 996 void LocalFrameClientImpl::AbortClientNavigation() {
998 if (web_frame_->Client()) 997 if (web_frame_->Client())
999 web_frame_->Client()->AbortClientNavigation(); 998 web_frame_->Client()->AbortClientNavigation();
1000 } 999 }
1001 1000
1002 TextCheckerClient& LocalFrameClientImpl::GetTextCheckerClient() const { 1001 TextCheckerClient& LocalFrameClientImpl::GetTextCheckerClient() const {
1003 return web_frame_->GetTextCheckerClient(); 1002 return web_frame_->GetTextCheckerClient();
1004 } 1003 }
1005 1004
1006 } // namespace blink 1005 } // namespace blink
OLDNEW
« no previous file with comments | « content/shell/test_runner/web_frame_test_proxy.h ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698