Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: content/shell/test_runner/web_frame_test_proxy.h

Issue 2829923003: Remove redundant WebLocalFrame* parameter from DidReceiveTitle (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_ 5 #ifndef CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_
6 #define CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_ 6 #define CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 Base::DidFailProvisionalLoad(error, commit_type); 118 Base::DidFailProvisionalLoad(error, commit_type);
119 } 119 }
120 120
121 void DidCommitProvisionalLoad( 121 void DidCommitProvisionalLoad(
122 const blink::WebHistoryItem& item, 122 const blink::WebHistoryItem& item,
123 blink::WebHistoryCommitType commit_type) override { 123 blink::WebHistoryCommitType commit_type) override {
124 test_client()->DidCommitProvisionalLoad(item, commit_type); 124 test_client()->DidCommitProvisionalLoad(item, commit_type);
125 Base::DidCommitProvisionalLoad(item, commit_type); 125 Base::DidCommitProvisionalLoad(item, commit_type);
126 } 126 }
127 127
128 void DidReceiveTitle(blink::WebLocalFrame* frame, 128 void DidReceiveTitle(const blink::WebString& title,
129 const blink::WebString& title,
130 blink::WebTextDirection direction) override { 129 blink::WebTextDirection direction) override {
131 test_client()->DidReceiveTitle(frame, title, direction); 130 test_client()->DidReceiveTitle(title, direction);
132 Base::DidReceiveTitle(frame, title, direction); 131 Base::DidReceiveTitle(title, direction);
133 } 132 }
134 133
135 void DidChangeIcon(blink::WebIconURL::Type icon_type) override { 134 void DidChangeIcon(blink::WebIconURL::Type icon_type) override {
136 test_client()->DidChangeIcon(icon_type); 135 test_client()->DidChangeIcon(icon_type);
137 Base::DidChangeIcon(icon_type); 136 Base::DidChangeIcon(icon_type);
138 } 137 }
139 138
140 void DidFinishDocumentLoad(blink::WebLocalFrame* frame) override { 139 void DidFinishDocumentLoad(blink::WebLocalFrame* frame) override {
141 test_client()->DidFinishDocumentLoad(frame); 140 test_client()->DidFinishDocumentLoad(frame);
142 Base::DidFinishDocumentLoad(frame); 141 Base::DidFinishDocumentLoad(frame);
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 return test_client()->RunFileChooser(params, completion); 289 return test_client()->RunFileChooser(params, completion);
291 } 290 }
292 291
293 private: 292 private:
294 DISALLOW_COPY_AND_ASSIGN(WebFrameTestProxy); 293 DISALLOW_COPY_AND_ASSIGN(WebFrameTestProxy);
295 }; 294 };
296 295
297 } // namespace test_runner 296 } // namespace test_runner
298 297
299 #endif // CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_ 298 #endif // CONTENT_SHELL_TEST_RUNNER_WEB_FRAME_TEST_PROXY_H_
OLDNEW
« no previous file with comments | « content/shell/test_runner/web_frame_test_client.cc ('k') | third_party/WebKit/Source/web/LocalFrameClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698