Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2829913002: Use __builtin_frame_address instead of inline assembly on non-Windows platforms. (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use __builtin_frame_address instead of inline assembly on non-Windows platforms. On ARM, this will automatically use the correct FP register depending on whether the VM is compiled to full ARM or Thumb. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/026fa0255d3d8170cfbd86738b82ca27ed902788

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M runtime/vm/globals.h View 1 1 chunk +3 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
3 years, 8 months ago (2017-04-24 18:00:42 UTC) #4
Cutch
lgtm
3 years, 8 months ago (2017-04-24 18:01:10 UTC) #5
rmacnak
3 years, 8 months ago (2017-04-24 18:12:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
026fa0255d3d8170cfbd86738b82ca27ed902788 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698