content/browser/download/download_job.h - Issue 2829853011: Polish the cleaning up url request code for parallel download.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_job.h

Issue 2829853011: Polish the cleaning up url request code for parallel download. (Closed)

Patch Set: Work on feedbacks. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_job.h

diff --git a/content/browser/download/download_job.h b/content/browser/download/download_job.h

index 2f12b18b1f098b820cd04eb004dec6df2b6c8332..cae4f1abae803d3d04f6e0c9eb0443aa424bc243 100644

--- a/content/browser/download/download_job.h

+++ b/content/browser/download/download_job.h

@@ -46,6 +46,7 @@ class CONTENT_EXPORT DownloadJob {

// Cancel a particular request starts from |offset|, while the download is not

// canceled. Used in parallel download.

+ // TODO(xingliu): Remove this function if download job owns download file.

virtual void CancelRequestWithOffset(int64_t offset);

protected: