Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9431)

Unified Diff: cc/layers/scrollbar_layer_unittest.cc

Issue 2829853009: cc : Add DCHECKs to ensure we have valid proprety tree indices at commit (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/scrollbar_layer_unittest.cc
diff --git a/cc/layers/scrollbar_layer_unittest.cc b/cc/layers/scrollbar_layer_unittest.cc
index 3120dbfe34e8e6d4bf7f5d4c13a6bf9741ef68c6..0ed9cf4e4d2923b6dcdb9c73ac4089dbbdd83585 100644
--- a/cc/layers/scrollbar_layer_unittest.cc
+++ b/cc/layers/scrollbar_layer_unittest.cc
@@ -386,6 +386,7 @@ TEST_F(ScrollbarLayerTest, UpdatePropertiesOfScrollBarWhenThumbRemoved) {
LayerImpl* root_clip_layer_impl = nullptr;
PaintedScrollbarLayerImpl* scrollbar_layer_impl = nullptr;
+ layer_tree_host_->BuildPropertyTreesForTesting();
UPDATE_AND_EXTRACT_LAYER_POINTERS();
EXPECT_EQ(gfx::Rect(10, 0, 4, 10).ToString(),
scrollbar_layer_impl->ComputeThumbQuadRect().ToString());
@@ -753,9 +754,7 @@ TEST_F(ScrollbarLayerTest, ScrollbarLayerPushProperties) {
scroll_layer->SetBounds(gfx::Size(20, 20));
scroll_layer->SetForceRenderSurfaceForTesting(true);
layer_tree_host_->UpdateLayers();
- host_impl->CreatePendingTree();
- layer_tree_host_->CommitAndCreatePendingTree();
- host_impl->ActivateSyncTree();
+ layer_tree_host_->CommitAndCreateLayerImplTree();
EffectNode* node =
host_impl->active_tree()->property_trees()->effect_tree.Node(
scrollbar_layer->effect_tree_index());

Powered by Google App Engine
This is Rietveld 408576698