Stores server card as a full server card when upload to server succeeds.

components/autofill/core/browser/webdata/autofill_table.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOFILL_TABLE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOFILL_TABLE_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 131 matching lines @@
 //                      Added in version 50.
 //   billing_address_id The guid string that identifies the local profile which
 //                      is the billing address for this card. Can be null in the
 //                      database, but always returned as an empty string in
 //                      CreditCard. Added in version 66.
 //
 // masked_credit_cards
 //                      This table contains "masked" credit card information
 //                      about credit cards stored on the server. It consists
 //                      of a short description and an ID, but not full payment
-//                      information. Writing to this table is only done by sync.
+//                      information. Writing to this table is done by sync and
+//                      on successful save of card to the server.
 //                      When a server card is unmasked, it will stay here and
 //                      will additionally be added in unmasked_credit_cards.
 //
 //   id                 String assigned by the server to identify this card.
 //                      This is opaque to the client.
 //   status             Server's status of this card.
 //                      TODO(brettw) define constants for this.
 //   name_on_card
 //   type               Type of the credit card. This is one of the
 //                      kSyncCardType* strings.
 //   last_four          Last four digits of the card number. For de-duping
 //                      with locally stored cards and generating descriptions.
 //   exp_month          Expiration month: 1-12
 //   exp_year           Four-digit year: 2017
 //
 // unmasked_credit_cards
 //                      When a masked credit credit card is unmasked and the
-//                      full number is downloaded, it will be stored here.
+//                      full number is downloaded or when the full number is
+//                      available upon saving card to server, it will be stored
+//                      here.
 //
 //   id                 Server ID. This can be joined with the id in the
 //                      masked_credit_cards table to get the rest of the data.
 //   card_number_encrypted
 //                      Full card number, encrypted.
 //   use_count          DEPRECATED in version 65. See server_card_metadata.
 //   use_date           DEPRECATED in version 65. See server_card_metadata.
 //                      TODO(crbug.com/682326): Remove deprecated columns.
 //   unmask_date        The date this card was unmasked in units of
 //                      Time::ToInternalValue. Added in version 64.
@@ skipping 168 matching lines @@
   // Records a single credit card in the credit_cards table.
   bool AddCreditCard(const CreditCard& credit_card);
 
   // Updates the database values for the specified credit card.
   bool UpdateCreditCard(const CreditCard& credit_card);
 
   // Removes a row from the credit_cards table.  |guid| is the identifier of the
   // credit card to remove.
   bool RemoveCreditCard(const std::string& guid);
 
+  // Adds to the masked_credit_cards and unmasked_credit_cards tables.
+  bool AddServerCreditCard(const CreditCard& credit_card);
+
   // Retrieves a credit card with guid |guid|.
   std::unique_ptr<CreditCard> GetCreditCard(const std::string& guid);
 
   // Retrieves the local/server credit cards in the database.
   virtual bool GetCreditCards(
       std::vector<std::unique_ptr<CreditCard>>* credit_cards);
   virtual bool GetServerCreditCards(
       std::vector<std::unique_ptr<CreditCard>>* credit_cards) const;
 
   // Replaces all server credit cards with the given vector. Unmasked cards
@@ skipping 155 matching lines @@
 
   // Insert a single AutofillEntry into the autofill table.
   bool InsertAutofillEntry(const AutofillEntry& entry);
 
   // Checks if the trash is empty.
   bool IsAutofillProfilesTrashEmpty();
 
   // Checks if the guid is in the trash.
   bool IsAutofillGUIDInTrash(const std::string& guid);
 
+  // Adds to |masked_credit_cards| and updates |server_card_metadata|.

[sebsg, 2017/04/24 19:18:23]

Can you add a comment that these should be called as part of a transaction?

Thanks!

[csashi, 2017/04/24 20:09:02]

Done. I also add a debug CHECK. Turns out that we were not starting a
transaction explicitly in UnmaskServerCreditCard - I changed that to start an
explicit transaction and commit it.

+  void AddMaskedCreditCards(const std::vector<CreditCard>& credit_cards);
+
+  // Adds to |unmasked_credit_cards|.
+  void AddUnmaskedCreditCard(const std::string& id,
+                             const base::string16& full_number);
+
+  // Deletes server credit cards by |id|. Returns true if a row was deleted.
+  bool DeleteFromMaskedCreditCards(const std::string& id);
+  bool DeleteFromUnmaskedCreditCards(const std::string& id);
+
   bool InitMainTable();
   bool InitCreditCardsTable();
   bool InitDatesTable();
   bool InitProfilesTable();
   bool InitProfileNamesTable();
   bool InitProfileEmailsTable();
   bool InitProfilePhonesTable();
   bool InitProfileTrashTable();
   bool InitMaskedCreditCardsTable();
   bool InitUnmaskedCreditCardsTable();
   bool InitServerCardMetadataTable();
   bool InitServerAddressesTable();
   bool InitServerAddressMetadataTable();
   bool InitAutofillSyncMetadataTable();
   bool InitModelTypeStateTable();
 
   std::unique_ptr<AutofillTableEncryptor> autofill_table_encryptor_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillTable);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_WEBDATA_AUTOFILL_TABLE_H_