[Fuchsia] Grab the number of malloc'd bytes from jemalloc

[Fuchsia] Grab the number of malloc'd bytes from jemalloc

This allows us to report the "native heap memory" value in
the Observatory for VMs running on Fuchsia.

This change also renames the flag --enable-malloc-hooks to
--profiler-native-memory to better reflect what the flag
does. (In the future we may also want to rename
--profiler to --profiler-cpu.)

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/135b1907ee6f9cd09817e0dfd5d5aa118c1033b8

[zra, 2017-04-19 22:28:50]

Description was changed from

==========
[Fuchsia] Grab the number of malloc'd bytes from jemalloc

This allows us to report the "native heap memory" value in
the Observatory for VMs running on Fuchsia.
==========

to

==========
[Fuchsia] Grab the number of malloc'd bytes from jemalloc

This allows us to report the "native heap memory" value in
the Observatory for VMs running on Fuchsia.

This change also renames the flag --enable-malloc-hooks to
--profiler-native-memory to better reflect what the flag
does. (In the future we may also want to rename
--profiler to --profiler-cpu.)
==========

[zra, 2017-04-19 22:29:07]

zra@google.com changed reviewers:
+ bkonyi@google.com, rmacnak@google.com

[bkonyi, 2017-04-19 22:43:02]

I'd image if we use jemalloc, we aren't using tcmalloc right? If so, do we not
want to collect stack traces for memory allocations as well on Fuchsia?

[rmacnak, 2017-04-19 22:43:59]

lgtm

https://codereview.chromium.org/2829833003/diff/20001/runtime/vm/malloc_hooks...
File runtime/vm/malloc_hooks_jemalloc.cc (right):

https://codereview.chromium.org/2829833003/diff/20001/runtime/vm/malloc_hooks...
runtime/vm/malloc_hooks_jemalloc.cc:6: #if defined(DART_USE_JEMALLOC) &&
!defined(PRODUCT) && !defined(TARGET_ARCH_DBC)
Not part of your change, but I don't see any reason DBC should be treated
specially.

[zra, 2017-04-19 22:51:07]

Description was changed from

==========
[Fuchsia] Grab the number of malloc'd bytes from jemalloc

This allows us to report the "native heap memory" value in
the Observatory for VMs running on Fuchsia.

This change also renames the flag --enable-malloc-hooks to
--profiler-native-memory to better reflect what the flag
does. (In the future we may also want to rename
--profiler to --profiler-cpu.)
==========

to

==========
[Fuchsia] Grab the number of malloc'd bytes from jemalloc

This allows us to report the "native heap memory" value in
the Observatory for VMs running on Fuchsia.

This change also renames the flag --enable-malloc-hooks to
--profiler-native-memory to better reflect what the flag
does. (In the future we may also want to rename
--profiler to --profiler-cpu.)

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/135b1907ee6f9cd09817e0dfd5d5aa118c1033b8
==========

[zra, 2017-04-19 22:51:08]

Committed patchset #2 (id:20001) manually as
135b1907ee6f9cd09817e0dfd5d5aa118c1033b8 (presubmit successful).

[zra, 2017-04-19 22:54:00]

On 2017/04/19 22:43:02, bkonyi wrote:
> I'd image if we use jemalloc, we aren't using tcmalloc right? If so, do we not
> want to collect stack traces for memory allocations as well on Fuchsia?

At the moment, I don't see any way to hook into the calls with jemalloc.
If/when we find a way to do that, we can collect the stack traces, etc.