Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: ui/views/controls/textfield/textfield_unittest.cc

Issue 2829823002: [Textfield] Consider select all status for select all context menu (Closed)
Patch Set: Cleanup test code Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/textfield/textfield.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield_unittest.cc
diff --git a/ui/views/controls/textfield/textfield_unittest.cc b/ui/views/controls/textfield/textfield_unittest.cc
index 71d3ad8ca556465e47b116b7506401dc885914d7..c765aac3856fead2ad66df383ccfdc22a4adc07c 100644
--- a/ui/views/controls/textfield/textfield_unittest.cc
+++ b/ui/views/controls/textfield/textfield_unittest.cc
@@ -649,6 +649,10 @@ class TextfieldTest : public ViewsTestBase, public TextfieldController {
void VerifyTextfieldContextMenuContents(bool textfield_has_selection,
bool can_undo,
ui::MenuModel* menu) {
+ const auto& text = textfield_->text();
+ const bool is_all_selected = !text.empty() &&
+ textfield_->GetSelectedRange().length() == text.length();
+
EXPECT_EQ(can_undo, menu->IsEnabledAt(0 /* UNDO */));
EXPECT_TRUE(menu->IsEnabledAt(1 /* Separator */));
EXPECT_EQ(textfield_has_selection, menu->IsEnabledAt(2 /* CUT */));
@@ -657,7 +661,7 @@ class TextfieldTest : public ViewsTestBase, public TextfieldController {
menu->IsEnabledAt(4 /* PASTE */));
EXPECT_EQ(textfield_has_selection, menu->IsEnabledAt(5 /* DELETE */));
EXPECT_TRUE(menu->IsEnabledAt(6 /* Separator */));
- EXPECT_TRUE(menu->IsEnabledAt(7 /* SELECT ALL */));
+ EXPECT_EQ(!is_all_selected, menu->IsEnabledAt(7 /* SELECT ALL */));
}
void PressMouseButton(ui::EventFlags mouse_button_flags, int extra_flags) {
« no previous file with comments | « ui/views/controls/textfield/textfield.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698