Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: services/ui/public/interfaces/window_manager.mojom

Issue 2829733002: mus: Changes SetDisplayRoot() to create actual display (Closed)
Patch Set: screenmanagerforwarding only ozone Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/public/interfaces/window_manager.mojom
diff --git a/services/ui/public/interfaces/window_manager.mojom b/services/ui/public/interfaces/window_manager.mojom
index aa340ba650b857fffb8ac9f6ec7654e0ea8808d6..2d2590436deb122a19dbdeea9b94714581bec126 100644
--- a/services/ui/public/interfaces/window_manager.mojom
+++ b/services/ui/public/interfaces/window_manager.mojom
@@ -16,6 +16,7 @@ import "ui/display/mojo/display.mojom";
import "ui/events/mojo/event.mojom";
import "ui/events/mojo/event_constants.mojom";
import "ui/gfx/geometry/mojo/geometry.mojom";
+import "ui/display/mojo/display.mojom";
// WindowManager is used when a WindowTreeClient attempts to modify
// a property of the embed root. When this happens WindowTree calls the
@@ -273,8 +274,13 @@ interface WindowManagerClient {
// Sets the root of a particular display. This is only applicable when the
// WindowTree was created with a value of false for
// |automatically_create_display_roots| (see
- // WindowManagerWindowTreeFactory::CreateWindowTree() for details).
- SetDisplayRoot(int64 display_id, uint32 window_id) => (bool success);
+ // WindowManagerWindowTreeFactory::CreateWindowTree() for details). On success
+ // this responds with the FrameSinkId of the root. On failure the FrameSinkId
+ // is not valid.
+ SetDisplayRoot(display.mojom.Display display,
kylechar 2017/04/19 18:06:08 This gets called initially once for each display r
sky 2017/04/19 19:30:02 That's right.
kylechar 2017/04/19 19:47:09 sgtm!
+ WmViewportMetrics viewport_metrics,
+ bool is_primary_display,
+ uint32 window_id) => (cc.mojom.FrameSinkId? frame_sink_id);
// The window manager has completed a request with the specific change id.
WmResponse(uint32 change_id, bool response);

Powered by Google App Engine
This is Rietveld 408576698