[DMC #1.912] Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersInternal()

third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
index a5490d17ec5fb1aff4444b9a268b32b06aa2871d..ae95edfdc097b9d3f9a6a7fa8ae8713a3c870046 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
@@ -79,11 +79,6 @@ class CORE_EXPORT DocumentMarkerController final
   void PrepareForDestruction();
   void RemoveMarkersInRange(const EphemeralRange&, DocumentMarker::MarkerTypes);
   void RemoveMarkers(
-      Node*,
-      unsigned start_offset,
-      int length,
-      DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
-  void RemoveMarkers(
       DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
   void RemoveMarkers(
       Node*,
@@ -136,6 +131,11 @@ class CORE_EXPORT DocumentMarkerController final
   bool PossiblyHasMarkers(DocumentMarker::MarkerTypes);
   void RemoveMarkersFromList(MarkerMap::iterator, DocumentMarker::MarkerTypes);
   void RemoveMarkers(TextIterator&, DocumentMarker::MarkerTypes);

[rlanday, 2017/04/21 03:51:13]

We already have another private RemoveMarkers() method, should we rename this
one too? Can we come up with something better than calling them both
RemoveMarkersInternal()?

[Xiaocheng, 2017/04/21 05:22:46]

If this function is the sink called by all other functions, it's fine to call it
RemoveMarkersInternal. It's the other private function that needs renaming.

Btw, this function doesn't need default parameter. Please add a TODO for
cleanup.

[rlanday, 2017/04/21 05:28:15]

I decided to just remove the default param in this CL (I'm also doing this in
the other renaming CLs, I just missed it here).

I think this method is correctly named as RemoveMarkersInternal(), the other one
should be something like RemoveMarkersForTextIterator()...

+  void RemoveMarkersInternal(
+      Node*,
+      unsigned start_offset,
+      int length,
+      DocumentMarker::MarkerTypes = DocumentMarker::AllMarkers());
 
   MarkerMap markers_;
   // Provide a quick way to determine whether a particular marker type is absent