Issue 28297: Implement gfx::Path on GTK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28297: Implement gfx::Path on GTK. (Closed)

Created:
11 years, 9 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, brettw, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -42 lines)			Patch
M	chrome/chrome.gyp	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	chrome/common/common.scons	View	4 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/common/common.vcproj	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/gfx/path.h	View	1 chunk	+17 lines, -7 lines	0 comments	Download
M	chrome/common/gfx/path.cc	View	1 chunk	+0 lines, -30 lines	0 comments	Download
A	chrome/common/gfx/path_gtk.cc	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	chrome/common/gfx/path_win.cc	View	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

Should be pretty straight forward. Brett: path Evan: gdk Mark: gyp

11 years, 9 months ago (2009-02-28 15:24:29 UTC) #1

Mark Mentovai

.gyp lgtm http://codereview.chromium.org/28297/diff/1/2 File chrome/chrome.gyp (right): http://codereview.chromium.org/28297/diff/1/2#newcode117 Line 117: 'common/gfx/path.h', .h should come first now ...

11 years, 9 months ago (2009-02-28 16:40:36 UTC) #2

brettw

11 years, 9 months ago (2009-03-02 04:36:39 UTC) #3

Both Windows and your new GDK code is wrong because it only does polygonal paths
(no curves)

This is OK, since I guess we only need that when we use this code. Can you add
comments on both functions in the header file that this is the case?

LGTM with this addition.

Expand Messages | Collapse Messages

Issue 28297: Implement gfx::Path on GTK. (Closed)

Description

Patch Set 1 #

Messages