Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2829693002: Move 'general function type' unit tests into mixins to run them with Fasta. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move 'general function type' unit tests into mixins to run them with Fasta. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0ce4611fd99696b105d8cfaedb259aaade26b2f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -170 lines) Patch
M pkg/analyzer/test/generated/parser_test.dart View 11 chunks +195 lines, -170 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-19 16:28:44 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-19 16:47:57 UTC) #2
scheglov
3 years, 8 months ago (2017-04-19 17:11:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ce4611fd99696b105d8cfaedb259aaade26b2f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698