Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: third_party/WebKit/Source/core/layout/line/InlineBox.cpp

Issue 2829683010: Optimize sizeof(InlineBox) by eliminating class layout padding (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineBox.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 21 matching lines...) Expand all
32 #ifndef NDEBUG 32 #ifndef NDEBUG
33 #include <stdio.h> 33 #include <stdio.h>
34 #endif 34 #endif
35 35
36 namespace blink { 36 namespace blink {
37 37
38 class LayoutObject; 38 class LayoutObject;
39 39
40 struct SameSizeAsInlineBox : DisplayItemClient { 40 struct SameSizeAsInlineBox : DisplayItemClient {
41 virtual ~SameSizeAsInlineBox() {} 41 virtual ~SameSizeAsInlineBox() {}
42 uint32_t bitfields;
43 void* a[4]; 42 void* a[4];
44 LayoutPoint b; 43 LayoutPoint b;
45 LayoutUnit c; 44 LayoutUnit c;
45 uint32_t bitfields;
46 #if DCHECK_IS_ON() 46 #if DCHECK_IS_ON()
47 bool f; 47 bool f;
48 #endif 48 #endif
49 }; 49 };
50 50
51 static_assert(sizeof(InlineBox) == sizeof(SameSizeAsInlineBox), 51 static_assert(sizeof(InlineBox) == sizeof(SameSizeAsInlineBox),
52 "InlineBox should stay small"); 52 "InlineBox should stay small");
53 53
54 #if DCHECK_IS_ON() 54 #if DCHECK_IS_ON()
55 InlineBox::~InlineBox() { 55 InlineBox::~InlineBox() {
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 } 390 }
391 391
392 void showLineTree(const blink::InlineBox* b) { 392 void showLineTree(const blink::InlineBox* b) {
393 if (b) 393 if (b)
394 b->ShowLineTreeForThis(); 394 b->ShowLineTreeForThis();
395 else 395 else
396 fprintf(stderr, "Cannot showLineTree for (nil) InlineBox.\n"); 396 fprintf(stderr, "Cannot showLineTree for (nil) InlineBox.\n");
397 } 397 }
398 398
399 #endif 399 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineBox.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698