Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2829683007: Extract DartTypeVisitor and subclasses from resolution_types. (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract DartTypeVisitor and subclasses from resolution_types. This makes most of the subtype related visitors reusable by kernel based elements. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8a9c0417af177068ee34e1d116fbc7ee4f2586c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -350 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 15 chunks +68 lines, -330 lines 0 comments Download
M pkg/compiler/lib/src/elements/types.dart View 8 chunks +349 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/type_serialization.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-20 10:40:36 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 8 months ago (2017-04-20 22:41:47 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-24 07:01:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a9c0417af177068ee34e1d116fbc7ee4f2586c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698