Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2829683006: Threading: Add thread checks in TaskRunnerHelper

Created:
3 years, 8 months ago by nhiroki
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Threading: Add thread checks in TaskRunnerHelper TODO - Count how many tests are failing because of this check (incl MessagePort) BUG=

Patch Set 1 : initial (600 layout tests failed on linux_chromium_rel_ng) #

Patch Set 2 : GlobalScopeScheduler / MessagePort fix (333 layout tests failed on linux_chromium_rel_ng) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 30 (30 generated)
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-20 06:29:11 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829683006/1
3 years, 8 months ago (2017-04-20 06:29:31 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-20 06:32:41 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/161506) chromium_presubmit on ...
3 years, 8 months ago (2017-04-20 06:32:42 UTC) #4
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-20 06:52:16 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829683006/20001
3 years, 8 months ago (2017-04-20 06:52:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-20 07:37:19 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/161518)
3 years, 8 months ago (2017-04-20 07:37:20 UTC) #8
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-20 10:50:34 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829683006/40001
3 years, 8 months ago (2017-04-20 10:50:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-20 10:59:25 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/401142)
3 years, 8 months ago (2017-04-20 10:59:26 UTC) #12
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-20 11:13:00 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829683006/60001
3 years, 8 months ago (2017-04-20 11:13:14 UTC) #14
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-20 11:15:12 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829683006/80001
3 years, 8 months ago (2017-04-20 11:15:27 UTC) #16
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-20 11:17:53 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829683006/100001
3 years, 8 months ago (2017-04-20 11:18:03 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-20 11:48:14 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/434936)
3 years, 8 months ago (2017-04-20 11:48:14 UTC) #20
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-21 02:18:36 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829683006/120001
3 years, 8 months ago (2017-04-21 02:18:58 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-21 03:08:20 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/162362)
3 years, 8 months ago (2017-04-21 03:08:21 UTC) #24
nhiroki
Description was changed from ========== Threading: Add thread checks in TaskRunnerHelper BUG= ========== to ========== ...
3 years, 8 months ago (2017-04-21 09:16:37 UTC) #25
nhiroki
Patchset #4 (id:60001) has been deleted
3 years, 8 months ago (2017-04-21 09:30:37 UTC) #26
nhiroki
Patchset #4 (id:80001) has been deleted
3 years, 8 months ago (2017-04-21 09:30:45 UTC) #27
nhiroki
Patchset #1 (id:1) has been deleted
3 years, 8 months ago (2017-04-21 09:30:55 UTC) #28
nhiroki
Patchset #3 (id:100001) has been deleted
3 years, 8 months ago (2017-04-21 09:31:28 UTC) #29
nhiroki
3 years, 8 months ago (2017-04-21 09:35:12 UTC) #30
Patchset #2 (id:40001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698