DevTools: update LASTCHANGE for uploader_iteration.sh

DevTools: update LASTCHANGE for uploader_iteration.sh

Make LASTCHANGE consistent with how it's normally generated.

Based on this CL comment:
https://codereview.chromium.org/1982423002/#msg24

BUG=none
R=dgozman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=b2200cc9a2c775374a34a3ee0d04c45607b3579e

[chenwilliam, 2017-04-20 00:17:42]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2017-04-20 00:17:43]

ptal. I applied this patch on the uploader GCE and verified it does what's
expected.

https://codereview.chromium.org/2829683005/diff/1/gce/uploader_iteration.sh
File gce/uploader_iteration.sh (right):

https://codereview.chromium.org/2829683005/diff/1/gce/uploader_iteration.sh#n...
gce/uploader_iteration.sh:135:
LASTCHANGE_BLINK_FILE="build/util/LASTCHANGE.blink"
I think it might be OK to stop generating this file, but I'm worried that new
commits on previously cut release branches might depend on the LASTCHANGE.blink
file. Doesn't seem to hurt to leave this in here, and I can remove it later.

[dgozman, 2017-04-20 16:49:34]

lgtm if it works locally on the uploader

https://codereview.chromium.org/2829683005/diff/1/gce/uploader_iteration.sh
File gce/uploader_iteration.sh (right):

https://codereview.chromium.org/2829683005/diff/1/gce/uploader_iteration.sh#n...
gce/uploader_iteration.sh:135:
LASTCHANGE_BLINK_FILE="build/util/LASTCHANGE.blink"
On 2017/04/20 00:17:43, chenwilliam wrote:
> I think it might be OK to stop generating this file, but I'm worried that new
> commits on previously cut release branches might depend on the
LASTCHANGE.blink
> file. Doesn't seem to hurt to leave this in here, and I can remove it later.

I vaguley remember the build/util/lastchange.py didn't work for us. Probably,
because of the partial checkout? Now that we have full checkout it should be ok,
right?

[chenwilliam, 2017-04-20 17:49:01]

On 2017/04/20 16:49:34, dgozman wrote:
> lgtm if it works locally on the uploader
> 
> https://codereview.chromium.org/2829683005/diff/1/gce/uploader_iteration.sh
> File gce/uploader_iteration.sh (right):
> 
>
https://codereview.chromium.org/2829683005/diff/1/gce/uploader_iteration.sh#n...
> gce/uploader_iteration.sh:135:
> LASTCHANGE_BLINK_FILE="build/util/LASTCHANGE.blink"
> On 2017/04/20 00:17:43, chenwilliam wrote:
> > I think it might be OK to stop generating this file, but I'm worried that
new
> > commits on previously cut release branches might depend on the
> LASTCHANGE.blink
> > file. Doesn't seem to hurt to leave this in here, and I can remove it later.
> 
> I vaguley remember the build/util/lastchange.py didn't work for us. Probably,
> because of the partial checkout? Now that we have full checkout it should be
ok,
> right?

Yep - I tried it locally on the uploader.

Dug through some history and I think I see what you're saying. It looks like in
the pre-Blink merge era, we only checked out WebKit and thus would not have
access to that script. https://codereview.chromium.org/1351373003

[chenwilliam, 2017-04-20 17:49:48]

Description was changed from

==========
DevTools: update LASTCHANGE for uploader_iteration.sh

Make LASTCHANGE consistent with how it's normally generated.

Based on this CL comment:
https://codereview.chromium.org/1982423002/#msg24

BUG=none
==========

to

==========
DevTools: update LASTCHANGE for uploader_iteration.sh

Make LASTCHANGE consistent with how it's normally generated.

Based on this CL comment:
https://codereview.chromium.org/1982423002/#msg24

BUG=none
R=dgozman@chromium.org

Committed:
https://src.chromium.org/viewvc/chrome?view=rev&revision=b2200cc9a2c775374a34...
==========

[chenwilliam, 2017-04-20 17:49:49]

Committed patchset #1 (id:1) manually as
b2200cc9a2c775374a34a3ee0d04c45607b3579e (presubmit successful).