third_party/WebKit/Source/core/frame/VisualViewport.cpp - Issue 2829613002: Remove ScheduleAnimation proxy methods, call HostWindow directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.cpp

Issue 2829613002: Remove ScheduleAnimation proxy methods, call HostWindow directly (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/VisualViewport.cpp

diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.cpp b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

index b5f5e4236d675625417e873faac8ad0f3cfd5ca9..cc2251298cae6ba96f87e7bc755dcae069422c48 100644

--- a/third_party/WebKit/Source/core/frame/VisualViewport.cpp

+++ b/third_party/WebKit/Source/core/frame/VisualViewport.cpp

@@ -675,7 +675,11 @@ LocalFrame* VisualViewport::MainFrame() const {

}

bool VisualViewport::ScheduleAnimation() {

- return MainFrame()->ScheduleAnimation(GetHostWindow());

+ if (HostWindow* window = GetHostWindow()) {

+ window->ScheduleAnimation(MainFrame());

+ return true;

+ }

+ return false;

}

void VisualViewport::ClampToBoundaries() {