Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2829533002: dart2js: --fast-startup: use alias for 'this' (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: --fast-startup: use alias for 'this' Cache `this` in a local if doing so makes the minified code smaller. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/deb986acce499350b135902c6270e1579081f5bb Reverted due to https://github.com/dart-lang/sdk/issues/29455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +23 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
Saves 0.36% on swarm, 1.67% on a huge angular app. The generated angular components have ...
3 years, 8 months ago (2017-04-19 02:38:48 UTC) #3
floitsch
LGTM.
3 years, 8 months ago (2017-04-19 09:12:59 UTC) #4
sra1
3 years, 8 months ago (2017-04-25 00:53:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
deb986acce499350b135902c6270e1579081f5bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698