Support input events in Chrome ASH on Windows 7.

Support input events in Chrome ASH on Windows 7.

All changes are in the metro_driver_win7.cc file. There are two classes MouseEvent and KeyboardEvent
which implement the required set of winrt interfaces needed for this to work. We call the corresponding
handlers in the ChromeAppViewAsh class on the same lines as ASH on Windows 8.

BUG=356475
R=cpu@chromium.org, cpu

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270558

[cpu_(ooo_6.6-7.5), 2014-05-14 00:49:37]

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
File win8/metro_driver/metro_driver_win7.cc (right):

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:152:
__FIVector_1_Windows__CUI__CInput__CPointerPoint** points) {
use the c++ type instead of the crazy C type.

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:363: virtual HRESULT STDMETHODCALLTYPE
get_SupportedUsages(
same here about the type.

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:364:
__FIVectorView_1_Windows__CDevices__CInput__CPointerDeviceUsage** usages) {
something weird about this line.

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:472: // Poor mans way of dispatching
input events.
man's

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:474: if (msg.message >= WM_KEYFIRST &&
msg.message <= WM_KEYLAST) {
can you put some ( ) around the tests, like 

 ((msg.message >= WM_KEYFIRST) && (msg.message <= WM_KEYLAST))

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:722: key_down_handler_ = handler;
lets use mswr::ComPtr<> for key_down_handler_ so we avoid this AddRef deal?

[ananta, 2014-05-14 00:59:13]

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
File win8/metro_driver/metro_driver_win7.cc (right):

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:152:
__FIVector_1_Windows__CUI__CInput__CPointerPoint** points) {
On 2014/05/14 00:49:38, cpu wrote:
> use the c++ type instead of the crazy C type. 

Done.

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:363: virtual HRESULT STDMETHODCALLTYPE
get_SupportedUsages(
On 2014/05/14 00:49:38, cpu wrote:
> same here about the type.

Done.

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:364:
__FIVectorView_1_Windows__CDevices__CInput__CPointerDeviceUsage** usages) {
On 2014/05/14 00:49:38, cpu wrote:
> something weird about this line.

Done.

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:472: // Poor mans way of dispatching
input events.
On 2014/05/14 00:49:38, cpu wrote:
> man's

Done.

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:474: if (msg.message >= WM_KEYFIRST &&
msg.message <= WM_KEYLAST) {
On 2014/05/14 00:49:38, cpu wrote:
> can you put some ( ) around the tests, like 
> 
>  ((msg.message >= WM_KEYFIRST) && (msg.message <= WM_KEYLAST))

Done.

https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
win8/metro_driver/metro_driver_win7.cc:722: key_down_handler_ = handler;
On 2014/05/14 00:49:38, cpu wrote:
> lets use mswr::ComPtr<> for key_down_handler_ so we avoid this AddRef deal?

We can't do that as we need to hold the reference for the lifetime of this
class.

[ananta, 2014-05-14 19:51:13]

On 2014/05/14 00:59:13, ananta wrote:
>
https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
> File win8/metro_driver/metro_driver_win7.cc (right):
> 
>
https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
> win8/metro_driver/metro_driver_win7.cc:152:
> __FIVector_1_Windows__CUI__CInput__CPointerPoint** points) {
> On 2014/05/14 00:49:38, cpu wrote:
> > use the c++ type instead of the crazy C type. 
> 
> Done.
> 
>
https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
> win8/metro_driver/metro_driver_win7.cc:363: virtual HRESULT STDMETHODCALLTYPE
> get_SupportedUsages(
> On 2014/05/14 00:49:38, cpu wrote:
> > same here about the type.
> 
> Done.
> 
>
https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
> win8/metro_driver/metro_driver_win7.cc:364:
> __FIVectorView_1_Windows__CDevices__CInput__CPointerDeviceUsage** usages) {
> On 2014/05/14 00:49:38, cpu wrote:
> > something weird about this line.
> 
> Done.
> 
>
https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
> win8/metro_driver/metro_driver_win7.cc:472: // Poor mans way of dispatching
> input events.
> On 2014/05/14 00:49:38, cpu wrote:
> > man's
> 
> Done.
> 
>
https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
> win8/metro_driver/metro_driver_win7.cc:474: if (msg.message >= WM_KEYFIRST &&
> msg.message <= WM_KEYLAST) {
> On 2014/05/14 00:49:38, cpu wrote:
> > can you put some ( ) around the tests, like 
> > 
> >  ((msg.message >= WM_KEYFIRST) && (msg.message <= WM_KEYLAST))
> 
> Done.
> 
>
https://codereview.chromium.org/282953003/diff/1/win8/metro_driver/metro_driv...
> win8/metro_driver/metro_driver_win7.cc:722: key_down_handler_ = handler;
> On 2014/05/14 00:49:38, cpu wrote:
> > lets use mswr::ComPtr<> for key_down_handler_ so we avoid this AddRef deal?
> 
> We can't do that as we need to hold the reference for the lifetime of this
> class.

Please take another look. Fixed a crash on win7 ash startup and scaling of mouse
events to work in
HiDPI.

[cpu_(ooo_6.6-7.5), 2014-05-14 20:01:55]

lgtm

https://codereview.chromium.org/282953003/diff/60001/win8/metro_driver/metro_...
File win8/metro_driver/metro_driver_win7.cc (right):

https://codereview.chromium.org/282953003/diff/60001/win8/metro_driver/metro_...
win8/metro_driver/metro_driver_win7.cc:483: HandleSystemKeys(msg);
can you make 479 - 491 into a member function so the pump while loop looks
pretty?

[ananta, 2014-05-14 20:16:17]

https://codereview.chromium.org/282953003/diff/60001/win8/metro_driver/metro_...
File win8/metro_driver/metro_driver_win7.cc (right):

https://codereview.chromium.org/282953003/diff/60001/win8/metro_driver/metro_...
win8/metro_driver/metro_driver_win7.cc:483: HandleSystemKeys(msg);
On 2014/05/14 20:01:55, cpu wrote:
> can you make 479 - 491 into a member function so the pump while loop looks
> pretty?

Done.

[ananta, 2014-05-14 20:16:54]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-05-14 20:18:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/282953003/80001

[commit-bot: I haz the power, 2014-05-14 23:18:07]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-14 23:34:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-14 23:34:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[ananta, 2014-05-15 01:43:49]

Committed patchset #7 manually as r270558 (presubmit successful).