Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 282953002: Remove failing expectations for pixel tests. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org, piman
Visibility:
Public.

Description

Remove failing expectations for pixel tests. R=kbr@chromium.org BUG=252046, 371592 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270785

Patch Set 1 #

Patch Set 2 : pixeltests-expectations: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
danakj
Here's the followup for https://codereview.chromium.org/281003002/
6 years, 7 months ago (2014-05-13 23:19:56 UTC) #1
Ken Russell (switch to Gerrit)
LGTM though you'll need to rebase this per the other CL.
6 years, 7 months ago (2014-05-13 23:22:03 UTC) #2
danakj
Yup! Thanks
6 years, 7 months ago (2014-05-13 23:24:12 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-15 19:37:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/282953002/40001
6 years, 7 months ago (2014-05-15 19:38:24 UTC) #5
commit-bot: I haz the power
Change committed as 270785
6 years, 7 months ago (2014-05-15 19:44:25 UTC) #6
Ken Russell (switch to Gerrit)
Thanks for cleaning this up. Next time though please don't use NOTRY=true for the removal ...
6 years, 7 months ago (2014-05-15 21:17:02 UTC) #7
danakj
On Thu, May 15, 2014 at 5:17 PM, <kbr@chromium.org> wrote: > Thanks for cleaning this ...
6 years, 7 months ago (2014-05-15 21:19:22 UTC) #8
Ken Russell (switch to Gerrit)
6 years, 7 months ago (2014-05-15 21:31:43 UTC) #9
Message was sent while issue was closed.
On 2014/05/15 21:19:22, danakj wrote:
> IOW wait for the first patch to finish the waterfall bots I guess? Sorry
> will do.

Yes. No problem. Since the Mac and Win try jobs don't yet block the CQ, there
would still have been a chance of failure. Racing to get them in place.

Powered by Google App Engine
This is Rietveld 408576698