Make conflicting summary check configurable

pkg/analyzer/test/src/summary/package_bundle_reader_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/summary/idl.dart';
 import 'package:analyzer/src/summary/package_bundle_reader.dart';
 import 'package:analyzer/src/task/dart.dart';
@@ skipping 130 matching lines @@
 
   test_compute_SOURCE_KIND_partSource() {
     bool success = provider.compute(entry2, SOURCE_KIND);
     expect(success, isTrue);
     expect(entry2.getValue(SOURCE_KIND), SourceKind.PART);
   }
 }
 
 @reflectiveTest
 class SummaryDataStoreTest {
-  SummaryDataStore dataStore =
-      new SummaryDataStore(<String>[], recordDependencyInfo: true);
+  SummaryDataStore dataStore = new SummaryDataStore(<String>[],
+      recordDependencyInfo: true, disallowOverlappingSummaries: true);
 
   PackageBundle bundle1 = new _PackageBundleMock();
   PackageBundle bundle2 = new _PackageBundleMock();
   UnlinkedUnit unlinkedUnit11 = new _UnlinkedUnitMock();
   UnlinkedUnit unlinkedUnit12 = new _UnlinkedUnitMock();
   UnlinkedUnit unlinkedUnit21 = new _UnlinkedUnitMock();
   LinkedLibrary linkedLibrary1 = new _LinkedLibraryMock();
   LinkedLibrary linkedLibrary2 = new _LinkedLibraryMock();
 
-  void setUp() {
+  void _setupDataStore(SummaryDataStore store) {
     // bundle1
     when(unlinkedUnit11.publicNamespace)
         .thenReturn(_namespaceWithParts(['package:p1/u2.dart']));
     when(unlinkedUnit12.publicNamespace).thenReturn(_namespaceWithParts([]));
     when(bundle1.unlinkedUnitUris)
         .thenReturn(<String>['package:p1/u1.dart', 'package:p1/u2.dart']);
     when(bundle1.unlinkedUnits)
         .thenReturn(<UnlinkedUnit>[unlinkedUnit11, unlinkedUnit12]);
     when(bundle1.linkedLibraryUris).thenReturn(<String>['package:p1/u1.dart']);
     when(bundle1.linkedLibraries).thenReturn(<LinkedLibrary>[linkedLibrary1]);
     when(bundle1.apiSignature).thenReturn('signature1');
-    dataStore.addBundle('/p1.ds', bundle1);
+    store.addBundle('/p1.ds', bundle1);
     // bundle2
     when(unlinkedUnit21.publicNamespace).thenReturn(_namespaceWithParts([]));
     when(bundle2.unlinkedUnitUris).thenReturn(<String>['package:p2/u1.dart']);
     when(bundle2.unlinkedUnits).thenReturn(<UnlinkedUnit>[unlinkedUnit21]);
     when(bundle2.linkedLibraryUris).thenReturn(<String>['package:p2/u1.dart']);
     when(bundle2.linkedLibraries).thenReturn(<LinkedLibrary>[linkedLibrary2]);
     when(bundle2.apiSignature).thenReturn('signature2');
-    dataStore.addBundle('/p2.ds', bundle2);
+    store.addBundle('/p2.ds', bundle2);
+  }
+
+  void setUp() {
+    _setupDataStore(dataStore);
   }
 
   test_addBundle() {
     expect(dataStore.bundles, unorderedEquals([bundle1, bundle2]));
     expect(dataStore.dependencies[0].summaryPath, '/p1.ds');
     expect(dataStore.dependencies[0].apiSignature, 'signature1');
     expect(dataStore.dependencies[0].includedPackageNames, ['p1']);
     expect(dataStore.dependencies[0].includesFileUris, false);
     expect(dataStore.dependencies[0].includesDartUris, false);
     expect(dataStore.dependencies[1].summaryPath, '/p2.ds');
@@ skipping 55 matching lines @@
         .thenReturn(<String>['package:p2/u1.dart', 'package:p1/u1.dart']);
     when(bundle.linkedLibraries)
         .thenReturn(<LinkedLibrary>[linkedLibrary2, linkedLibrary1]);
     when(bundle.apiSignature).thenReturn('signature');
     // p3 conflicts (overlaps) with existing summaries.
     expect(() => dataStore.addBundle('/p3.ds', bundle),
         throwsA(isConflictingSummaryException));
     expect(dataStore.dependencies.last.includedPackageNames, ['p1', 'p2']);
   }
 
+  test_addBundle_multiProjectOverlap() {
+    SummaryDataStore dataStore2 = new SummaryDataStore(<String>[],
+        recordDependencyInfo: true, disallowOverlappingSummaries: false);
+    _setupDataStore(dataStore2);
+
+    PackageBundle bundle = new _PackageBundleMock();
+    when(bundle.unlinkedUnitUris)
+        .thenReturn(<String>['package:p2/u1.dart', 'package:p1/u1.dart']);
+    when(bundle.unlinkedUnits)
+        .thenReturn(<UnlinkedUnit>[unlinkedUnit21, unlinkedUnit11]);
+    when(bundle.linkedLibraryUris)
+        .thenReturn(<String>['package:p2/u1.dart', 'package:p1/u1.dart']);
+    when(bundle.linkedLibraries)
+        .thenReturn(<LinkedLibrary>[linkedLibrary2, linkedLibrary1]);
+    when(bundle.apiSignature).thenReturn('signature');
+    // p3 conflicts (overlaps) with existing summaries, but now allowed.
+    dataStore2.addBundle('/p3.ds', bundle);
+    expect(dataStore2.dependencies.last.includedPackageNames, ['p1', 'p2']);
+  }
+
   test_getContainingLibraryUris_libraryUri() {
     String partUri = 'package:p1/u1.dart';
     List<String> uris = dataStore.getContainingLibraryUris(partUri);
     expect(uris, unorderedEquals([partUri]));
   }
 
   test_getContainingLibraryUris_partUri() {
     String partUri = 'package:p1/u2.dart';
     List<String> uris = dataStore.getContainingLibraryUris(partUri);
     expect(uris, unorderedEquals(['package:p1/u1.dart']));
@@ skipping 52 matching lines @@
 class _UnlinkedUnitMock extends TypedMock implements UnlinkedUnit {}
 
 /// A matcher for ConflictingSummaryException.
 const Matcher isConflictingSummaryException =
     const _ConflictingSummaryException();
 
 class _ConflictingSummaryException extends TypeMatcher {
   const _ConflictingSummaryException() : super("ConflictingSummaryException");
   bool matches(item, Map matchState) => item is ConflictingSummaryException;
 }