Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2829463003: Format all remaining unformatted runtime files other than multitests. (Closed)

Created:
3 years, 8 months ago by Jacob
Modified:
3 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Format all remaining unformatted runtime files other than multitests. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b67e83eea3a4438d16bffc0e0485941045e3a052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -205 lines) Patch
M runtime/bin/stdio_patch.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/loader.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/server.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/allocation_profile.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_ref.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_view.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_ref.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart View 4 chunks +10 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile_table.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 3 chunks +21 lines, -24 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 3 chunks +7 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/metric/details.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/metrics.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/vm_menu.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/sample_buffer_control.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/stack_trace_tree_config.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/get_source_report_test.dart View 1 chunk +123 lines, -110 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart View 3 chunks +7 lines, -12 lines 0 comments Download
M runtime/observatory/tests/service/set_library_debuggable_test.dart View 2 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
3 years, 8 months ago (2017-04-18 22:00:18 UTC) #2
Cutch
Rubber Stamp LGTM
3 years, 8 months ago (2017-04-18 22:20:57 UTC) #3
Jacob
3 years, 8 months ago (2017-04-18 22:34:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b67e83eea3a4438d16bffc0e0485941045e3a052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698