Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 2829433003: Enable frame pointers explicitly under ARM32. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | build/config/compiler/compiler.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 630db84f14be471ba134fa4bb559c5808e25cbff..320b7fce75bb11af6037a317aecf98aaeb47c8f4 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1385,12 +1385,7 @@ config("default_stack_frames") {
if (enabled_frame_pointers) {
cflags = [ "-fno-omit-frame-pointer" ]
} else {
- if (is_android || current_cpu != "arm") {
- # TODO(710131): Remove this special-casing for ARM 32 bit once we
- # have determined why -fomit-frame-pointer triggers CPU errata in
- # ARM A12/A17 devices.
- cflags = [ "-fomit-frame-pointer" ]
- }
+ cflags = [ "-fomit-frame-pointer" ]
}
}
# On Windows, the flag to enable framepointers "/Oy-" must always come after
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | build/config/compiler/compiler.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698