Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2829253002: Add support for external summaries bundle in AnalysisDriver. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for external summaries bundle in AnalysisDriver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6ad782027abbcb387d116e446a59fccdb6fd4f58

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixes for review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -86 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 6 chunks +34 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 6 chunks +43 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_tracker.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_context.dart View 9 chunks +20 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 4 chunks +66 lines, -50 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 3 chunks +25 lines, -19 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-21 15:58:55 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2829253002/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right): https://codereview.chromium.org/2829253002/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart#newcode99 pkg/analyzer/lib/src/dart/analysis/file_state.dart:99: * Return `true` is this file is a ...
3 years, 8 months ago (2017-04-21 16:19:39 UTC) #2
scheglov
3 years, 8 months ago (2017-04-21 16:38:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6ad782027abbcb387d116e446a59fccdb6fd4f58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698