Check equivalence of closed world based on kernel elements.

pkg/compiler/lib/src/world.dart

Index: pkg/compiler/lib/src/world.dart
diff --git a/pkg/compiler/lib/src/world.dart b/pkg/compiler/lib/src/world.dart
index 59ee9b2561449c8f930f39ef2d16a53ffa31baee..71f0e0bb4b5f78628454e3c819895d77575d8ae2 100644
--- a/pkg/compiler/lib/src/world.dart
+++ b/pkg/compiler/lib/src/world.dart
@@ -1100,6 +1100,19 @@ abstract class ClosedWorldBase implements ClosedWorld, ClosedWorldRefiner {
   bool getCurrentlyKnownMightBePassedToApply(Entity element) {
     return getMightBePassedToApply(element);
   }
+
+  @override
+  String dump([ClassElement cls]) {

[Siggi Cherem (dart-lang), 2017/04/21 17:04:21]

now that this is shared, should Element be Entity?

[Johnni Winther, 2017/04/24 09:53:46]

The implementation actually still requires the argument to be a [ClassElement]
adding a TODO.

+    StringBuffer sb = new StringBuffer();
+    if (cls != null) {
+      sb.write("Classes in the closed world related to $cls:\n");
+    } else {
+      sb.write("Instantiated classes in the closed world:\n");
+    }
+    getClassHierarchyNode(commonElements.objectClass)
+        .printOn(sb, ' ', instantiatedOnly: cls == null, withRespectTo: cls);
+    return sb.toString();
+  }
 }
 
 class ClosedWorldImpl extends ClosedWorldBase {
@@ -1235,19 +1248,6 @@ class ClosedWorldImpl extends ClosedWorldBase {
     }
   }
 
-  @override
-  String dump([ClassElement cls]) {
-    StringBuffer sb = new StringBuffer();
-    if (cls != null) {
-      sb.write("Classes in the closed world related to $cls:\n");
-    } else {
-      sb.write("Instantiated classes in the closed world:\n");
-    }
-    getClassHierarchyNode(commonElements.objectClass)
-        .printOn(sb, ' ', instantiatedOnly: cls == null, withRespectTo: cls);
-    return sb.toString();
-  }
-
   SideEffects getSideEffectsOfElement(Element element) {
     // The type inferrer (where the side effects are being computed),
     // does not see generative constructor bodies because they are
@@ -1341,11 +1341,6 @@ class KernelClosedWorld extends ClosedWorldBase {
   }
 
   @override
-  String dump([ClassEntity cls]) {
-    throw new UnimplementedError('KernelClosedWorld.dump');
-  }
-
-  @override
   bool hasElementIn(ClassEntity cls, Selector selector, Entity element) {
     throw new UnimplementedError('KernelClosedWorld.hasElementIn');
   }