Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2829223003: Check equivalence of closed world based on kernel elements. (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check equivalence of closed world based on kernel elements. An equivalent closed world can now be computed for the Hello World program based purely on kernel-based elements. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/82ea1dafc9da9cdfc837f6c7054161b929f607a7

Patch Set 1 #

Patch Set 2 : Test hello world! #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -137 lines) Patch
M pkg/compiler/lib/src/kernel/world_builder.dart View 1 2 chunks +45 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 2 chunks +24 lines, -95 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 3 chunks +130 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 2 3 chunks +14 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 4 chunks +9 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 7 chunks +25 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
3 years, 8 months ago (2017-04-21 08:38:06 UTC) #3
Siggi Cherem (dart-lang)
fantastic! lgtm https://codereview.chromium.org/2829223003/diff/20001/pkg/compiler/lib/src/kernel/world_builder.dart File pkg/compiler/lib/src/kernel/world_builder.dart (right): https://codereview.chromium.org/2829223003/diff/20001/pkg/compiler/lib/src/kernel/world_builder.dart#newcode1129 pkg/compiler/lib/src/kernel/world_builder.dart:1129: return false; throw? https://codereview.chromium.org/2829223003/diff/20001/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): ...
3 years, 8 months ago (2017-04-21 17:04:21 UTC) #4
Johnni Winther
Committed patchset #3 (id:40001) manually as 82ea1dafc9da9cdfc837f6c7054161b929f607a7 (presubmit successful).
3 years, 8 months ago (2017-04-24 09:33:24 UTC) #6
Johnni Winther
3 years, 8 months ago (2017-04-24 09:53:46 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/2829223003/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/world_builder.dart (right):

https://codereview.chromium.org/2829223003/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/world_builder.dart:1129: return false;
On 2017/04/21 17:04:21, Siggi Cherem (dart-lang) wrote:
> throw?

Needed for the closed world computation.

https://codereview.chromium.org/2829223003/diff/20001/pkg/compiler/lib/src/wo...
File pkg/compiler/lib/src/world.dart (right):

https://codereview.chromium.org/2829223003/diff/20001/pkg/compiler/lib/src/wo...
pkg/compiler/lib/src/world.dart:1105: String dump([ClassElement cls]) {
On 2017/04/21 17:04:21, Siggi Cherem (dart-lang) wrote:
> now that this is shared, should Element be Entity?

The implementation actually still requires the argument to be a [ClassElement]
adding a TODO.

Powered by Google App Engine
This is Rietveld 408576698