Autopresent WebVR content in CCT if it was opened by a Daydream Intent

chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.customtabs;
 
 import android.app.PendingIntent;
 import android.content.Context;
 import android.content.Intent;
 import android.content.SharedPreferences;
@@ skipping 56 matching lines @@
 import org.chromium.chrome.browser.tabmodel.ChromeTabCreator;
 import org.chromium.chrome.browser.tabmodel.EmptyTabModelObserver;
 import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
 import org.chromium.chrome.browser.tabmodel.TabModelObserver;
 import org.chromium.chrome.browser.tabmodel.TabModelSelector;
 import org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl;
 import org.chromium.chrome.browser.tabmodel.TabReparentingParams;
 import org.chromium.chrome.browser.toolbar.ToolbarControlContainer;
 import org.chromium.chrome.browser.util.ColorUtils;
 import org.chromium.chrome.browser.util.UrlUtilities;
+import org.chromium.chrome.browser.vr_shell.VrShellDelegate;
 import org.chromium.chrome.browser.widget.findinpage.FindToolbarManager;
 import org.chromium.components.dom_distiller.core.DomDistillerUrlUtils;
 import org.chromium.content_public.browser.LoadUrlParams;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.ui.base.PageTransition;
 import org.chromium.ui.base.WindowAndroid;
 
 /**
  * The activity for custom tabs. It will be launched on top of a client's task.
  */
@@ skipping 438 matching lines @@
         if (!mHasCreatedTabEarly && !successfulStateRestore) {
             loadUrlInTab(mMainTab, new LoadUrlParams(url),
                     IntentHandler.getTimestampFromIntent(getIntent()));
         }
 
         // Put Sync in the correct state by calling tab state initialized. crbug.com/581811.
         getTabModelSelector().markTabStateInitialized();
         super.finishNativeInitialization();
     }
 
+    @Override
+    public final boolean shouldAutoPresent() {

[mthiesse, 2017/04/21 14:24:27]

If you call this shouldAutoPresentOnVrIntent(), you can simply return true for
CCT, and deal with the logic of when we get a VR intent inside VrShellDelegate.

[bshe, 2017/04/21 17:54:01]

See below. It looks like VrShellDelegate wont get intent from this activity by
onNewIntentWithNative,
which I assume is what you mean.

+        return VrShellDelegate.isDaydreamVrIntent(getIntent());

[mthiesse, 2017/04/21 14:24:27]

Instead of using getIntent(), you should have VrShellDelegate listen to
onNewIntentWithNative, so that we only present when we first get the intent, and
not later on if the intent hasn't changed.

[bshe, 2017/04/21 17:54:01]

If I understand correctly, onNewIntentWithNative wont be called since this is
not launched
in singleTop mode.
I add a log in the overrided function and it doesnt seem to be called.

[mthiesse, 2017/04/21 18:35:39]

Why look at the intent at all? Why not tie into CCT startup, and see if the
creator of the CCT was a daydream activity?

[Yusuf, 2017/04/21 23:10:38]

I am assuming they dont connect through our service which means it is not
possible to verify what type of Activity they are?

Or is there a VR specific way of checking this?

[bshe, 2017/04/24 13:59:12]

There is no VR specific way of checking it. For issue 713369, we will make sure
it connect through CCT service so it is possible to verify it. In general, we
don't have a way to verify that in VR.

+    }
+
     /**
      * Encapsulates CustomTabsConnection#takeHiddenTab()
      * with additional initialization logic.
      */
     private Tab getHiddenTab(CustomTabsConnection connection) {
         String url = getUrlToLoad();
         String referrerUrl = connection.getReferrer(mSession, getIntent());
         Tab tab = connection.takeHiddenTab(mSession, url, referrerUrl);
         mUsingHiddenTab = tab != null;
         if (!mUsingHiddenTab) return null;
@@ skipping 597 matching lines @@
         Intent intent = ChromeLauncherActivity.createCustomTabActivityIntent(
                 context, customTabIntent.intent, false);
         intent.setPackage(context.getPackageName());
         intent.putExtra(CustomTabIntentDataProvider.EXTRA_IS_INFO_PAGE, true);
         intent.putExtra(Browser.EXTRA_APPLICATION_ID, context.getPackageName());
         IntentHandler.addTrustedIntentExtras(intent);
 
         context.startActivity(intent);
     }
 }