Issue 2829113002: Make AstFactory.variableDeclaration(charOffset) a required parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2829113002: Make AstFactory.variableDeclaration(charOffset) a required parameter. (Closed)

Created:
3 years, 8 months ago by Paul Berry

Modified:
3 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Make AstFactory.variableDeclaration(charOffset) a required parameter. This prevents bugs where we forget to set the offset. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/f9189fdfe27712c04fa960219e2261e541d20805

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -13 lines)			Patch
M	pkg/front_end/lib/src/fasta/builder/ast_factory.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View	3 chunks	+7 lines, -9 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/kernel/kernel_ast_factory.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 8 months ago (2017-04-20 17:31:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f9189fdfe27712c04fa960219e2261e541d20805 (presubmit successful).