Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: src/compiler/verifier.cc

Issue 2829093002: [turbofan] Avoid creating singleton state-values for the accumulator. (Closed)
Patch Set: Improve comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 2ba9ebbe0b13cb6d0cf717b7edfc910da791cc59..8c57265941605ac72d968d3ab9256245d07d35c8 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -509,12 +509,19 @@ void Verifier::Visitor::Check(Node* node) {
CHECK_EQ(0, control_count);
CHECK_EQ(0, effect_count);
CHECK_EQ(6, input_count);
- for (int i = 0; i < 3; ++i) {
+ // Check that the parameters and registers are kStateValues or
+ // kTypedStateValues.
+ for (int i = 0; i < 2; ++i) {
CHECK(NodeProperties::GetValueInput(node, i)->opcode() ==
IrOpcode::kStateValues ||
NodeProperties::GetValueInput(node, i)->opcode() ==
IrOpcode::kTypedStateValues);
}
+ // The accumulator (InputAt(2)) cannot be kStateValues, but it can be
+ // kTypedStateValues (to signal the type). Once AST graph builder
+ // is removed, we should check this here. Until then, AST graph
+ // builder can generate expression stack as InputAt(2), which can
+ // still be kStateValues.
break;
}
case IrOpcode::kStateValues:
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698