Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2829033002: Rename KernelWorldBuilder to KernelElementBuilder (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename KernelWorldBuilder to KernelElementBuilder - and make K*Env classes private R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/98b41dd1fc18a1a048983861a57f3c629ac72cfc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename to KernelToElementMap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -1359 lines) Patch
A + pkg/compiler/lib/src/kernel/element_map.dart View 1 35 chunks +79 lines, -84 lines 0 comments Download
M pkg/compiler/lib/src/kernel/native_basic_data.dart View 1 1 chunk +7 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/kernel/native_class_resolver.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/no_such_method_resolver.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/types.dart View 1 4 chunks +19 lines, -20 lines 0 comments Download
D pkg/compiler/lib/src/kernel/world_builder.dart View 1 1 chunk +0 lines, -1198 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/dill_loader_test.dart View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 8 chunks +18 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-20 10:37:11 UTC) #2
Siggi Cherem (dart-lang)
yay! we just need to iterate on the name, but the change lgtm https://codereview.chromium.org/2829033002/diff/1/pkg/compiler/lib/src/kernel/element_builder.dart File ...
3 years, 8 months ago (2017-04-20 22:39:39 UTC) #3
Johnni Winther
https://codereview.chromium.org/2829033002/diff/1/pkg/compiler/lib/src/kernel/element_builder.dart File pkg/compiler/lib/src/kernel/element_builder.dart (right): https://codereview.chromium.org/2829033002/diff/1/pkg/compiler/lib/src/kernel/element_builder.dart#newcode36 pkg/compiler/lib/src/kernel/element_builder.dart:36: class KernelElementBuilder extends KernelElementAdapterMixin { On 2017/04/20 22:39:39, Siggi ...
3 years, 8 months ago (2017-04-24 15:24:01 UTC) #4
Johnni Winther
3 years, 8 months ago (2017-04-24 15:29:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
98b41dd1fc18a1a048983861a57f3c629ac72cfc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698