chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc - Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h ('k') | content/test/data/android/permission_frame_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

index 96e6b0c72dcc20a06e2c800a34702caf8b439618..c40afcde9864f777a0998e5632ab7cc315508aa8 100644

--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

@@ -426,8 +426,11 @@ void PermissionPromptImpl::Show() {

GetAnchorArrow());

}

-bool PermissionPromptImpl::CanAcceptRequestUpdate() {

- return !(bubble_delegate_ && bubble_delegate_->IsMouseHovered());

+bool PermissionPromptImpl::MaybeCancelRequest() {

+ if (bubble_delegate_->IsMouseHovered())

+ return false;

+ Hide();

+ return true;

}

bool PermissionPromptImpl::HidesAutomatically() {