chrome/browser/ui/permission_bubble/mock_permission_prompt.cc - Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/permission_bubble/mock_permission_prompt.cc

Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/permission_bubble/mock_permission_prompt.cc

diff --git a/chrome/browser/ui/permission_bubble/mock_permission_prompt.cc b/chrome/browser/ui/permission_bubble/mock_permission_prompt.cc

index 2618143e41f8bf3b7f10a5e75ccce78ab04c2a2e..c8db9df7433e120e8288588478a8af8256651995 100644

--- a/chrome/browser/ui/permission_bubble/mock_permission_prompt.cc

+++ b/chrome/browser/ui/permission_bubble/mock_permission_prompt.cc

@@ -25,7 +25,9 @@ void MockPermissionPrompt::Show() {

is_visible_ = true;

}

-bool MockPermissionPrompt::CanAcceptRequestUpdate() {

+bool MockPermissionPrompt::MaybeCancelRequest() {

+ if (can_update_ui_)

+ Hide();

return can_update_ui_;

}