Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: chrome/browser/ui/permission_bubble/mock_permission_prompt.cc

Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled (Closed)
Patch Set: comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/permission_bubble/mock_permission_prompt.cc
diff --git a/chrome/browser/ui/permission_bubble/mock_permission_prompt.cc b/chrome/browser/ui/permission_bubble/mock_permission_prompt.cc
index 1f6ce0a83708dad1d1ee106154ecb61e45baba22..658024efd5cfcc30775aae093e858f9b693810a2 100644
--- a/chrome/browser/ui/permission_bubble/mock_permission_prompt.cc
+++ b/chrome/browser/ui/permission_bubble/mock_permission_prompt.cc
@@ -15,6 +15,8 @@ MockPermissionPrompt::~MockPermissionPrompt() {
void MockPermissionPrompt::Show(const std::vector<PermissionRequest*>& requests,
const std::vector<bool>& accept_state) {
+ if (IsVisible())
+ return;
factory_->ShowView(this);
factory_->show_count_++;
factory_->requests_count_ = manager_->requests_.size();
@@ -23,7 +25,9 @@ void MockPermissionPrompt::Show(const std::vector<PermissionRequest*>& requests,
is_visible_ = true;
}
-bool MockPermissionPrompt::CanAcceptRequestUpdate() {
+bool MockPermissionPrompt::MaybeCancelRequest() {
+ if (can_update_ui_)
+ Hide();
return can_update_ui_;
}

Powered by Google App Engine
This is Rietveld 408576698