chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h - Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h

Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled (Closed)

Patch Set: comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_request_manager.cc ('K') | « chrome/browser/permissions/permission_request_manager.cc ('k') | chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h

diff --git a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h

index d697a9ff6c1533fe4e0298b3ece11263ada4c885..c1875cd0bbccf064ad570a80f7ebaa34de898fb4 100644

--- a/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h

+++ b/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h

@@ -29,7 +29,7 @@ class PermissionBubbleCocoa : public PermissionPrompt {

void Hide() override;

bool IsVisible() override;

void SetDelegate(Delegate* delegate) override;

- bool CanAcceptRequestUpdate() override;

+ bool MaybeCancelRequest() override;

bool HidesAutomatically() override;

void UpdateAnchorPosition() override;

gfx::NativeWindow GetNativeWindow() override;