Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(243)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: content/test/data/android/permission_frame_test.html
Issue
2829023002
:
Fix cancelling permission requests on Android when the PermissionRequestManager is enabled (Closed)
Patch Set: rebase
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/android/BUILD.gn
chrome/android/java_sources.gni
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionFrameTest.java
chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java
chrome/browser/permissions/permission_prompt_android.h
chrome/browser/permissions/permission_prompt_android.cc
chrome/browser/permissions/permission_request_manager.cc
chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.h
chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa.mm
chrome/browser/ui/permission_bubble/mock_permission_prompt.h
chrome/browser/ui/permission_bubble/mock_permission_prompt.cc
chrome/browser/ui/permission_bubble/permission_prompt.h
chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h
chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
content/test/data/android/permission_frame_test.html
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
3
<iframe id=iframe srcdoc="
4
<script>
5
navigator.geolocation.getCurrentPosition(function() { });
6
</script>
7
"></iframe>
8
9
<script>
10
function navigateIFrame() {
11
iframe.contentWindow.location = "about:blank";
12
}
13
14
function requestGeolocation() {
15
navigator.geolocation.getCurrentPosition(function() { });
16
}
17
</script>
OLD
NEW
« no previous file with comments
|
« chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
('k') |
no next file »
|
no next file with comments »
Issue 2829023002: Fix cancelling permission requests on Android when the PermissionRequestManager is enabled (Closed)
Created 3 years, 8 months ago by Timothy Loh
Modified 3 years, 6 months ago
Reviewers: raymes
Base URL:
Comments: 4
This is Rietveld
408576698
Chromium Code Reviews
Issue 2829023002:
Fix cancelling permission requests on Android when the PermissionRequestManager is enabled (Closed)
