Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: ui/views/widget/widget_hwnd_utils.cc

Issue 2829013003: Set is_translucent even when Aero is disabled.
Patch Set: change comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_hwnd_utils.cc
diff --git a/ui/views/widget/widget_hwnd_utils.cc b/ui/views/widget/widget_hwnd_utils.cc
index 163e4b54b033c904237190867d81efef01f3c6bc..f64f9a513fa619762a769372c2a66ba76a4e774a 100644
--- a/ui/views/widget/widget_hwnd_utils.cc
+++ b/ui/views/widget/widget_hwnd_utils.cc
@@ -4,8 +4,6 @@
#include "ui/views/widget/widget_hwnd_utils.h"
-#include <dwmapi.h>
-
#include "base/command_line.h"
#include "build/build_config.h"
#include "ui/base/l10n/l10n_util_win.h"
@@ -151,11 +149,12 @@ void ConfigureWindowStyles(
// not have not have WM_SIZEBOX, WS_THICKFRAME or WS_CAPTION in its
// style.
//
- // This doesn't work when Aero is disabled, so disable it in that case.
- // Software composited windows can continue to use WS_EX_LAYERED.
+ // This doesn't work when Aero is disabled, but leave the flag on so
+ // software composited windows can continue to use WS_EX_LAYERED. Code that
+ // would create translucent hardware-composited windows should do something
+ // else instead.
bool is_translucent =
- (params.opacity == Widget::InitParams::TRANSLUCENT_WINDOW &&
- (ui::win::IsAeroGlassEnabled() || params.force_software_compositing));
+ (params.opacity == Widget::InitParams::TRANSLUCENT_WINDOW);
CalculateWindowStylesFromInitParams(params, widget_delegate,
native_widget_delegate, is_translucent,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698