Chromium Code Reviews
Help | Chromium Project | Sign in
(30)

Issue 2829008: Disk cache: Switch the disk cache to use the cache_thread.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by rvargas (out until 9-8)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Disk cache: Switch the disk cache to use the cache_thread. Add an InFlightBackendIO class that handles posting of cacheoperations back and forth between the IO thread and the cachethread. BUG=26730 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51312

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : Add file_posix.cc #

Patch Set 4 : remove unintended change from set 3 #

Total comments: 22

Patch Set 5 : Address comments #

Patch Set 6 : Fix tools #

Total comments: 2

Patch Set 7 : Rename some methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1326 lines, -844 lines) Patch
M net/disk_cache/backend_impl.h View 1 2 3 4 5 10 chunks +40 lines, -9 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 1 2 3 4 5 6 17 chunks +228 lines, -87 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 2 3 4 5 6 11 chunks +66 lines, -14 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.h View 4 chunks +7 lines, -1 line 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 3 5 chunks +26 lines, -7 lines 0 comments Download
M net/disk_cache/entry_impl.h View 1 2 3 4 5 6 2 chunks +15 lines, -2 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 1 2 3 4 5 6 13 chunks +117 lines, -40 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 12 chunks +33 lines, -25 lines 0 comments Download
M net/disk_cache/eviction.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/file_posix.cc View 4 chunks +11 lines, -2 lines 0 comments Download
A net/disk_cache/in_flight_backend_io.h View 2 3 4 5 1 chunk +200 lines, -0 lines 0 comments Download
A net/disk_cache/in_flight_backend_io.cc View 2 3 4 5 6 1 chunk +448 lines, -0 lines 0 comments Download
A + net/disk_cache/in_flight_io.h View 4 chunks +48 lines, -299 lines 0 comments Download
A + net/disk_cache/in_flight_io.cc View 3 chunks +17 lines, -332 lines 0 comments Download
M net/disk_cache/sparse_control.cc View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M net/disk_cache/stress_cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 1 2 3 4 5 6 12 chunks +25 lines, -5 lines 0 comments Download
M net/tools/dump_cache/upgrade.cc View 1 2 3 4 5 6 chunks +33 lines, -12 lines 0 comments Download
Project "None" does not have a commit queue.

Messages

Total messages: 12 (0 generated)
rvargas (out until 9-8)
As I mentioned before, this CL will be followed by a cleanup one that removes/moves ...
5 years, 2 months ago (2010-06-18 01:52:12 UTC) #1
tonyg
This is a pretty major architecture change. It would take me quite some time to ...
5 years, 2 months ago (2010-06-18 17:35:13 UTC) #2
rvargas (out until 9-8)
Nicolas has reviewed most of the changes to the disk cache, but he has been ...
5 years, 2 months ago (2010-06-18 18:22:19 UTC) #3
nsylvain
a few initial comments, in addition to the ones we talked about in person. I ...
5 years, 2 months ago (2010-06-23 21:09:28 UTC) #4
rvargas (out until 9-8)
Thanks. http://codereview.chromium.org/2829008/diff/44001/32002 File net/disk_cache/backend_impl.cc (right): http://codereview.chromium.org/2829008/diff/44001/32002#newcode428 net/disk_cache/backend_impl.cc:428: background_queue_.WaitForPendingIO(); On 2010/06/23 21:09:28, nsylvain wrote: > is ...
5 years, 2 months ago (2010-06-23 21:49:22 UTC) #5
nsylvain
On Wed, Jun 23, 2010 at 2:49 PM, <rvargas@chromium.org> wrote: > Thanks. > > > ...
5 years, 2 months ago (2010-06-23 22:00:10 UTC) #6
nsylvain
a few more comments http://codereview.chromium.org/2829008/diff/44001/32012 File net/disk_cache/in_flight_backend_io.cc (right): http://codereview.chromium.org/2829008/diff/44001/32012#newcode400 net/disk_cache/in_flight_backend_io.cc:400: if (!op->IsEntryOperation() && !pending_ops_.empty()) { ...
5 years, 2 months ago (2010-06-25 20:57:49 UTC) #7
rvargas (out until 9-8)
http://codereview.chromium.org/2829008/diff/44001/32002 File net/disk_cache/backend_impl.cc (right): http://codereview.chromium.org/2829008/diff/44001/32002#newcode762 net/disk_cache/backend_impl.cc:762: background_queue_.EndEnumeration(*iter); On 2010/06/23 21:49:22, rvargas wrote: > On 2010/06/23 ...
5 years, 2 months ago (2010-06-25 21:22:57 UTC) #8
nsylvain
i dont think you uploaded the last version yet, but, as far as I can ...
5 years, 2 months ago (2010-06-28 15:54:57 UTC) #9
rvargas (out until 9-8)
Uploaded, thanks. On 2010/06/28 15:54:57, nsylvain wrote: > i dont think you uploaded the last ...
5 years, 2 months ago (2010-06-28 19:39:00 UTC) #10
nsylvain
still lgtm with the new proxy change http://codereview.chromium.org/2829008/diff/15005/4020 File net/tools/crash_cache/crash_cache.cc (right): http://codereview.chromium.org/2829008/diff/15005/4020#newcode174 net/tools/crash_cache/crash_cache.cc:174: int rv ...
5 years, 2 months ago (2010-06-28 23:58:49 UTC) #11
rvargas (out until 9-8)
5 years, 2 months ago (2010-06-29 01:00:45 UTC) #12
Thanks

http://codereview.chromium.org/2829008/diff/15005/4020
File net/tools/crash_cache/crash_cache.cc (right):

http://codereview.chromium.org/2829008/diff/15005/4020#newcode174
net/tools/crash_cache/crash_cache.cc:174: int rv =
disk_cache::CreateCacheBackend(net::MEDIA_CACHE, path, 0, false,
On 2010/06/28 23:58:50, nsylvain wrote:
> why?

Added a comment. MEDIA_CACHE uses an LRU for evictions and this makes this code
go through the proper sequence of events.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c33a7a4