Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2829003005: Test service as minimum repro for sharing memory handle (Closed)

Created:
3 years, 8 months ago by chfremer
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT INTENDED FOR LANDING Adds a test service for reproducing an issue with sending a shared memory handle from a Mojo service to a client. The test fails on OSX but passes on other platforms. TEST=service_unittests --gtest_filter="TestServiceTest.ReceiveTestBufferHandle"

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -1 line) Patch
M services/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
A services/test/BUILD.gn View 1 chunk +59 lines, -0 lines 0 comments Download
A services/test/public/interfaces/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
A services/test/public/interfaces/service.mojom View 1 chunk +13 lines, -0 lines 0 comments Download
A services/test/service_impl.h View 1 chunk +48 lines, -0 lines 0 comments Download
A services/test/service_impl.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A services/test/service_main.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A services/test/service_manifest.json View 1 chunk +15 lines, -0 lines 0 comments Download
A services/test/service_unittest.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A services/test/service_unittest_manifest.json View 1 chunk +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (8 generated)
Ken Rockot(use gerrit already)
3 years, 8 months ago (2017-04-25 07:37:11 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698