Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: pkg/compiler/lib/src/library_loader.dart

Issue 2829003003: supress hint when using "show dynamic". This is a temporary fix to hide a hint (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.library_loader; 5 library dart2js.library_loader;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'common/names.dart' show Uris; 9 import 'common/names.dart' show Uris;
10 import 'common/tasks.dart' show CompilerTask, Measurer; 10 import 'common/tasks.dart' show CompilerTask, Measurer;
(...skipping 1317 matching lines...) Expand 10 before | Expand all | Expand 10 after
1328 if (combinator.isHide) { 1328 if (combinator.isHide) {
1329 if (library.isPackageLibrary && 1329 if (library.isPackageLibrary &&
1330 reporter.options.hidePackageWarnings) { 1330 reporter.options.hidePackageWarnings) {
1331 // Only report hide hint on packages if we show warnings on these: 1331 // Only report hide hint on packages if we show warnings on these:
1332 // The hide may be non-empty in some versions of the package, in 1332 // The hide may be non-empty in some versions of the package, in
1333 // which case you shouldn't remove the combinator. 1333 // which case you shouldn't remove the combinator.
1334 continue; 1334 continue;
1335 } 1335 }
1336 reporter.reportHintMessage(identifier, MessageKind.EMPTY_HIDE, 1336 reporter.reportHintMessage(identifier, MessageKind.EMPTY_HIDE,
1337 {'uri': library.canonicalUri, 'name': name}); 1337 {'uri': library.canonicalUri, 'name': name});
1338 } else { 1338 } else if (!library.isDartCore || name != 'dynamic') {
1339 // TODO(sigmund): remove this condition, we don't report a hint for
1340 // `import "dart:core" show dynamic;` until our tools match in
1341 // semantics (see #29125).
1339 reporter.reportHintMessage(identifier, MessageKind.EMPTY_SHOW, 1342 reporter.reportHintMessage(identifier, MessageKind.EMPTY_SHOW,
1340 {'uri': library.canonicalUri, 'name': name}); 1343 {'uri': library.canonicalUri, 'name': name});
1341 } 1344 }
1342 } 1345 }
1343 } 1346 }
1344 } 1347 }
1345 } 1348 }
1346 } 1349 }
1347 1350
1348 /** 1351 /**
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
1678 } 1681 }
1679 1682
1680 /// API used by the library loader to synchronously scan a library or 1683 /// API used by the library loader to synchronously scan a library or
1681 /// compilation unit and ensure that their library tags are computed. 1684 /// compilation unit and ensure that their library tags are computed.
1682 abstract class ElementScanner { 1685 abstract class ElementScanner {
1683 void scanLibrary(LibraryElement library); 1686 void scanLibrary(LibraryElement library);
1684 void scanUnit(CompilationUnitElement unit); 1687 void scanUnit(CompilationUnitElement unit);
1685 } 1688 }
1686 1689
1687 const _reuseLibrarySubtaskName = "Reuse library"; 1690 const _reuseLibrarySubtaskName = "Reuse library";
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698